Problem/Motivation

@mglaman released version 1.1.34 of mglaman/phpstan-drupal (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.34)
Looking at https://www.drupal.org/node/3060/qa it removes some false positives on Level 1.

Steps to reproduce

See https://www.drupal.org/node/3060/qa and notice the failures on both updated deps jobs for 10.0.x, 10.1.xand 11.x

Proposed resolution

- Upgrade mglaman/phpstan-drupal
- Create a new baseline (vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon)
- Bump version of mglaman/phpstan-drupal in composer.json to 1.1.34, since the newly created baseline won't pass on any version below that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3362569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !4043

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This change is very simple and does exactly what is in the IS. Looks great.

  • catch committed 5062db5e on 11.x 
    Issue #3362569 by Spokje: Update mglaman/phpstan-drupal and make daily "...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked back to 10.1.x, thanks!

  • catch committed ede92c59 on 10.1.x 
    Issue #3362569 by Spokje: Update mglaman/phpstan-drupal and make daily "...

Spokje closed merge request !4043

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.