Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Amongst the current suppressions found in the PHPStan level 1 baseline, introduce by the adding of phpstan/phpstan-phpunit, is: @covers value foo references an invalid class or function..
This issue exists to fix all of those.
Steps to reproduce
- Run PHPStan on level 1 and see the above issue amongst all others.
Proposed resolution
- Solve all of the reported issues for the above mentioned.
- Run PHPStan on level 1 and don't see the above issue any more.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3351095
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3351095-fix-phpstan-l1
changes, plain diff MR !3749
Comments
Comment #3
spokjeComment #4
daffie commentedFor the 2 remarks on the PR.
Comment #5
spokjeComment #6
daffie commentedAll my remarks have been addressed.
For me it is RTBC.
Comment #7
spokjeRebased after #3351218: Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." was committed.
Comment #8
spokjeRebased after #3351073: Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." was committed.
NOTE: There's still one open thread in the MR that might(?) need some more input before committing.
Comment #9
longwaveComment #10
spokjeAddressed last open thread.
Comment #11
daffie commentedAll the changes look good to me.
Back to RTBC.
Comment #12
spokjeMerge blocked: fast-forward merge is not possible. To merge this request, first rebase locally.Comment #13
spokjeComment #14
spokjeThanks @daffie, back to RTBC after rebase.
Comment #17
longwaveCommitted and pushed to 10.1.x, thanks!