Problem/Motivation

In #3326239: Add phpstan/phpstan-phpunit as a dev dependency we added phpstan/phpstan-phpunit which added new suppressions in our PHPStan baseline core/phpstan-baseline.neon.

This META-issue exists to create child issues to get rid of all of them.

Steps to reproduce

Here's a link which show all the newly introduced suppresions: https://git.drupalcode.org/project/drupal/-/commit/947fd48d2bba8ba1bca6a...

Here's an MR where we tried to fix most of them already, but the scope became to big: https://git.drupalcode.org/project/drupal/-/merge_requests/3095/diffs

Proposed resolution

- Create child issues for (probably?) each type of error.
- Fix the errors.
- Review
- Commit
- Close this META when all the suppression are handled.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Spokje created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [META] Fix PHPStan baseline suppressions introduced with phpstan/phpstan-unit » [META] Fix PHPStan baseline suppressions introduced with phpstan/phpstan-phpunit
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented

Thanks @longwave, must have hit a caffeine-low there...

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Fixed

All sub-issues are fixed, closing this one as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.