Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Amongst the current suppressions found in the PHPStan level 1 baseline, introduce by the adding of phpstan/phpstan-phpunit, is: You should use assertFoo() instead of assertSame(Foo, $actual)..
This issue exists to fix all of those.
NOTE: There's a separate issue for You should use assertNull() instead of assertSame(null, $actual). #3351060: Fix PHPStan L1 errors "You should use assertNull() instead of assertSame(null, $actual).", so these won't be fixed in here.
Steps to reproduce
- Run PHPStan on level 1 and see the above issue amongst all others.
Proposed resolution
- Solve all of the reported issues for the above mentioned.
- Run PHPStan on level 1 and don't see the above issue any more.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3351079
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3351079-fix-phpstan-l1
changes, plain diff MR !3746
Comments
Comment #3
spokjeComment #4
spokjeComment #5
spokjeComment #6
spokjeComment #7
smustgrave commentedApplied the patch and searched for "assertSame" in the phpstan-baseline file and only instances I found were of " You should use assertNull() instead of assertSame.." which was handled in the other ticket.
Comment #9
catchCommitted 6ca4984 and pushed to 10.1.x. Thanks!