Automatically install pg_trgm extension on PostgreSQL 13+

1. +++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
   @@ -298,6 +298,11 @@ public function initializeDatabase() {
   +      if (version_compare($connection->version(), 13, '>=')) {
   

   Can we change 13 to '13.0.0'. That is how the function version_compare() works. See: https://www.php.net/manual/en/function.version-compare.php

2. Can we add a @todo to remove the if-statement in Drupal 11. The minimum required version for PostgreSQL will become 14.

@m.stenta: Good find! Thanks.

added updated patch and address #3

+++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
@@ -298,6 +298,15 @@ public function initializeDatabase() {
+      /**
+       * @todo Remove this if-statement in Drupal 11 when the minimum required version for
+       * PostgreSQL becomes 14.
+       */

Can we change this to:

       // @todo Remove this if-statement in Drupal 11 when the minimum required
       // version for PostgreSQL becomes 13 or higher.

We should not go over the 80 characters per line. See: https://www.drupal.org/docs/develop/standards/php/php-coding-standards#l...

added wrong file address comment #5 but still there is some issue

@Akram Khan: I have updated my comment #5. Thank you for responding so fast to my review. It was a bit too fast. ;) Could you update the patch a second time?

yes @daffie sorry for that

I have asked to the testbot maintainer @hestenet on Drupal Slack for a testbot with PostgreSQL 12 and PHP 8.1. As this is a fix for PostgreSQL 13 and higher, we should make sure that it works with PostgreSQL 12. As for Drupal 10 the minimum required version for PostgreSQL is 12.

+++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
@@ -298,6 +298,13 @@ public function initializeDatabase() {
+      // @todo Remove this if-statement in Drupal 11 when the minimum required version for

Could you remove "version for" from the end of the line. Thank for working on this issue.

Sorry for the wrong file that i added @daffie now address your comment

Shout out to hestenet for adding the new postgre test combos

I'm seeing all green and believe that's what was needed.

Giving @hestenet issue credit for setting up the testbot with PHP 8.1 en PostgreSQL 12.

Giving @wotnak issue credits for his work in #3270558: Install and create the postgres pg_trgm extension in docker container.

1. +++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
   @@ -298,6 +298,13 @@ public function initializeDatabase() {
   +      // @todo Remove this if-statement in Drupal 11 when the minimum required
   ...
        catch (\Exception $e) {
   

   @todo statements should have a link to an issue, see @todo: To Do notes. That helps them be found and reduce the risk of duplicates. There isn't an issue for this yet, as can be seen in #3214954: [11.x] [meta] Set Drupal 11 platform and browser requirements at least six months before the release.

2. +++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
   @@ -298,6 +298,13 @@ public function initializeDatabase() {
   +      // If we are running PostgreSQL >= 13, enable the pg_trgm extension.
   

   This can be simpler, "Enable pg_trgrm for PostgreSQL 13 or higher."

3. +++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
   @@ -298,6 +298,13 @@ public function initializeDatabase() {
   +      if (version_compare($connection->version(), '13.0.0', '>=')) {
   

   This is comparing with '13.0.0' but the PostgreSQL docs state that the version numbers are 2 digits. And this is supported by the lists of versions at https://www.postgresql.org/docs/release/13.0/. I use ddev and the installed version was "13.10 (Debian 13.10-1.pgdg110+1)" which is also two digits. So, if I was running 13.0 this would return false and the extension would not be installed. If it really is two digits then this should be changed.

The comments in #20 by quietone should be addressed with this patch.

As stated in #20.3 the versions since postgre 10 are now 2 digits. for example "13.10" or "15.2". So I've adjusted this check.

All points of @quietone have been addressed.
Back to RTBC.

I have tested this manually and I am not sure how is this supposed to work? When I create a database manually (without pg_trgm), and try to install Drupal with this patch, then on the first form submit (on the setup database step) I get an error:

Error message
Resolve all issues below to continue the installation. For help configuring your database server, see the installation handbook, or contact your hosting provider.

• The pg_trgm PostgreSQL extension is not present. The extension is required by Drupal 10 to improve performance when using PostgreSQL. See Drupal database server requirements for more information.

If I submit the form second time, the error is gone and the installation will continue. Is it possible that the extension is created only after the requirements check triggered the error already? See here:

class Tasks extends InstallTasks {
  ...

  /**
   * Constructs a \Drupal\pgsql\Driver\Database\pgsql\Install\Tasks object.
   */
  public function __construct() {
    ...

    $this->tasks[] = [
      'function' => 'checkExtensions',
      'arguments' => [],
    ];
    $this->tasks[] = [
      'function' => 'initializeDatabase',
      'arguments' => [],
    ];
  }

Tested on PostgreSQL 13, with non-superuser account.

@poker10: Thanks!

The following patch moves the code to enable the extension to the checkExtensions function. The code only runs once during site installation so it doesn't matter that we put it here. Also it wont enable the extension if it already exist.

Moved the creation of the extension to before the checking of the extension exists.
Back to RTBC.

Tested this manually with unprivileged user and installation on both databases (with and without the extension enabled) completed successfully. +1 for this patch. Thanks!

Committed and pushed c9412349f8 to 11.x (10.2.x). Thanks!

Could use release note or CR

Added CR: https://www.drupal.org/node/3368754

Not sure it is worth a release note, it only affects new installs.