This issue centralizes the coordination and prioritization for all issues tagged Needs upstream bugfix
or needs upstream feature
โ i.e. issues that require coordination with the CKEditor 5 team upstream.
@lauriii and @Wim Leers did the prioritization in a Google Spreadsheet (everyone can view & comment!). See methodology below.
Prioritized list
- #3384400: [upstream] [Table] CKEditor 5 changes <thead> and keeps only a single <tbody>, which impedes screen reader accessibility of HTML tables
- #3332416: CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports
๐ The top 2 (of the remaining ones โ see "fixed" list below) have a significantly higher priority than the bottom 10! โ ๏ธ
- #3333494: [upstream] CKE5 Code Blocks missing type around wrapper
- #3335991: [upstream] [GHS] CKEditor 5 does not retain custom HTML tags that are not defined by CKEditor 5 plugins whenever /.*/ is not allowed (e.g. when filter_html is enabled)
- #3362002: [upstream] [GHS] CKEditor 5 stripping <h2> tags (and more) if inside <div>
- #3398223: [upstream] [Style] [GHS] empty elements do not work: <br class>, <hr class>, <col class> etc.
- #3395434: [upstream] [Table] CKEditor 5 editing table with rowspans removes header property
- #3280124: [PP-1] [upstream] Consider allowing styles for non-HTML5 tags
- #3259367: [upstream] Allow configuring *which* HTML tags can be aligned
- #3231168: [upstream] Adding   in source editor adds to the end of lines
Obsolete
#3339741: Clicking on an anchor link within a WYSIWYG navigates to anchorโ not upstream bug per #3339741-7: Clicking on an anchor link within a WYSIWYG navigates to anchor#3342874: Allow inline HTML comments in CKEditor 5โ not upstream bug per #3342874-17: Allow inline HTML comments in CKEditor 5
Fixed
- 10.1.0
-
- โ #3339763: [upstream] CKEditor 5 mangles table structure โ fixed in CKEditor 37, shipped in Drupal 10.1: #3355358: Update CKEditor 5 to 37.1.0
- 10.1.1
-
- โ #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 โ and <a> allows applying it to all elements โ fixed in CKEditor 38.1.0, shipped in Drupal 10.1.1: #3370989: Update CKEditor 5 to 38.1.0
- โ #3349893: [upstream] [GHS] CKEditor 5 removes <a>s that wrap HTML elements not natively supported by CKEditor 5 โ fixed in CKEditor 38.1.0, shipped in Drupal 10.1.1: #3370989: Update CKEditor 5 to 38.1.0
- 10.1.3
-
- โ #3337298: [upstream] [GHS] CKEditor 5 removes empty inline elements โ fixed in CKEditor 39.0.0, shipped in Drupal 10.1.3: #3377562: Update CKEditor 5 to 39.0.0
- 10.2.0
-
- โ #3321296: [upstream] CKEditor 5 breaks website CLS (no image width and height attributes) โ fixed in CKEditor 40.0.0, shipped in Drupal 10.2.0: #3393557: [upstream] Update CKEditor 5 to 40.0.0
- โ #3254346: [upstream] CKEditor 5 PasteFromOffice plugin should not allow MS Office/Apple Pages/Google Docs-specific classes and styles even when HTML is unrestricted โ fixed in CKEditor 40.1.0, shipped in Drupal 10.2.0: #3400791: Update CKEditor 5 to 40.1.0
- 10.6.0 / 11.3.0
-
- โ #3321254: [upstream] Remove Format button does not remove `style` attributes from block-level elements โ fixed in CKEditor v46.0.0, shipped in Drupal 10.6.0 / 11.3.0: #3538768: Update CKEditor 5 to 47.0.0
- 11.4.0
-
- โ #3331158: Support full-screen editing in CKEditor โ fixed in Drupal 11.4.0
Methodology
For each issue, we specified:
- Reach (% of sites affected
- Impact (1โ10, with: data loss = 10, semantics loss = 9, inconvenience = 1)
- โ multiply these to get a "Drupal priority" โ color coded based on this: red = very high impact, orange = high, yellow = medium, gray = low
- Effort to fix on Drupal side to determine if we should work around the problem on the Drupal side instead (0โ1 โ impossible/unmaintainable = 1, feasible = 0.5, easy = 0.25)
- โ multiply the effort with the Drupal priority to get a "CKEditor 5 priority" โ sorted based on this
This gives us an ordered list of issues, to clearly indicate which CKEditor 5 issues are most important for the Drupal ecosystem/community to get fixed.
Comments
Comment #3
wim leersComment #4
wim leersClarifying that everyone can comment on the spreadsheet โ although of course you can post it here too if you disagree with one of the assessments that @lauriii and I made.
Comment #5
wim leersJust met with @Reinmar from CKEditor 5!
He agrees with the prioritized list. Posted additional information on the top 4:
(The fifth issue @lauriii and I proposed to tackle on the Drupal side: #3332416-16: CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports.)
Comment #6
wim leersGood news, looks like #3339741 is not an upstream bug after all! See #3339741-7: Clicking on an anchor link within a WYSIWYG navigates to anchor.
Comment #7
wim leersNew issue prioritized: #3342874: Allow inline HTML comments in CKEditor 5. This one is ranked similarly to #3335991: [upstream] [GHS] CKEditor 5 does not retain custom HTML tags that are not defined by CKEditor 5 plugins whenever /.*/ is not allowed (e.g. when filter_html is enabled): reach 1%, impact 10 (because data loss), effort 1 on Drupal side (because impossible to fix by us).
Comment #8
wim leersThe 4th highest priority issue #3339763 will be fixed in the next CKEditor 5 release: #3339763-8: [upstream] CKEditor 5 mangles table structure ๐
Comment #9
wim leersNew very high priority issue with data loss: #3349893: [upstream] [GHS] CKEditor 5 removes <a>s that wrap HTML elements not natively supported by CKEditor 5.
Comment #10
wim leers#3339763: [upstream] CKEditor 5 mangles table structure was fixed in #3355358: Update CKEditor 5 to 37.1.0 ๐
Comment #11
wim leersComment #12
joshuami@Wim Leers, do you think we could add 3283173 to this list.
CKEditor 5 seems to support block level elements within a list item or table cell, but Drupal's implementation is stripping this valid syntax per HTML 5.
See https://ckeditor.com/docs/ckeditor5/latest/features/lists/document-lists....
Or am I thinking of this incorrectly, it's technically not blocked upstream, it's blocked in our implementation. ๐ค
Comment #14
wim leers#3349893: [upstream] [GHS] CKEditor 5 removes <a>s that wrap HTML elements not natively supported by CKEditor 5 is fixed, will ship with
10.1.1๐Comment #15
wim leers#3337298: [upstream] [GHS] CKEditor 5 removes empty inline elements is fixed, will ship with
10.1.3๐Comment #16
wim leers#3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 โ and <a> allows applying it to all elements is fixed, has already shipped with
10.1.1โ was waiting only for the functional JS test coverage to catch potential future regressions ๐ฅณComment #17
wim leersAdding fragments to releases.
Comment #18
wim leers#3321296: [upstream] CKEditor 5 breaks website CLS (no image width and height attributes) will be fixed by updating to CKEditor 5 v40.0.0 in #3393557: [upstream] Update CKEditor 5 to 40.0.0, which will ship with
10.2.0.Comment #19
wim leersTriaged 4 new issues into the spreadsheet together with @lauriii:
Also marked #3342874: Allow inline HTML comments in CKEditor 5 as obsolete, because it's not an upstream bug per #3342874-17: Allow inline HTML comments in CKEditor 5, and is RTBC ๐
Comment #20
wim leersComment #21
andrew.wang commentedMoving #3254346: [upstream] CKEditor 5 PasteFromOffice plugin should not allow MS Office/Apple Pages/Google Docs-specific classes and styles even when HTML is unrestricted to the Fixed section.
Comment #23
andrew.wang commentedMoving the following to the Fixed section: