Problem/Motivation

Follow up from #3239980: Deprecate Modernizr

From @xjm

The dictionary, libraries, cspell, .eslintrc.json, and vendor-update.js mentions should be removed in the D11 followup. (Maybe it would make sense to file it as postponed now, so we don't miss those parts?) However, I think that the mention in touchevents-test.js should be removed.

Steps to reproduce

NA

Proposed resolution

Remove references to modernizer

Remaining tasks

Merge #3239980: Deprecate Modernizr
Remove references
Review

User interface changes

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3334920

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

spokje’s picture

Version: 10.1.x-dev » 11.0.x-dev
Issue summary: View changes
gábor hojtsy’s picture

Title: Remove references to modernizer » [11.x] Remove references to modernizer
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

quietone’s picture

Title: [11.x] Remove references to modernizer » Remove references to modernizer
Status: Postponed » Active
Parent issue: » #3402452: [meta] Requirements for tagging 11.0.0-alpha1

While this is not a requirement I am adding to the alpha1 meta so we can keep track.

Spokje changed the visibility of the branch 3334920-10.3.x-resync-cspell-dict to hidden.

spokje’s picture

Opened #3425304: Resync dictionary.txt to resync cspell dictionary.

I _think_ this MR won't have any dictionary changes after that, but let's see.

spokje’s picture

Status: Active » Needs review

The only remaining references to modernizr in the MR is are core/misc/touchevents-test.js, and that leads to its appearance in core/misc/cspell/dictionary.txt.
According to #3239980-41: Deprecate Modernizr and #3239980-42: Deprecate Modernizr this is fine.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Did a search for Modernizr and as mentioned only 2 instances mentioned are the only things I found.

  • catch committed 0697c814 on 11.x
    Issue #3334920 by Spokje, smustgrave: Remove references to modernizer
    
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

We should revisit whether we really need touchevents any more too, I had a quick check and found #3375181: Deprecate the touchevents JavaScript library and update CSS which is already open.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.