Add 'Is empty (NULL)' and 'Is not empty (NOT NULL)' operators to boolean field filtering

Thanks for splitting this off.

Crediting @akalata here for the work they did adding it in #2769407: Add Boolean field filter option 'Treat NULL values as FALSE' to expose the already existing code path for handling this

Checked the patch again, looks good, has nice test coverage.

This:

+  protected function operatorValues($values = 1) {

Feels a bit weak but that is how other handlers manage this too, so ¯\_(ツ)_/¯

+++ b/core/modules/views/src/Plugin/views/filter/BooleanOperator.php
@@ -210,13 +254,17 @@ public function adminSummary() {
     if (empty($this->valueOptions)) {
-      $this->getValueOptions();
+      if (in_array($this->operator, $this->operatorValues(1), TRUE)) {
+        $this->getValueOptions();
+        // Now that we have the valid options for this filter, just return the
+        // human-readable label based on the current value.  The valueOptions
+        // array is keyed with either 0 or 1, so if the current value is not
+        // empty, use the label for 1, and if it's empty, use the label for 0.
+        return $this->operator . ' ' . $this->valueOptions[!empty($this->value)];
+      }
+
+      return $this->operator;
     }
-    // Now that we have the valid options for this filter, just return the
-    // human-readable label based on the current value.  The valueOptions
-    // array is keyed with either 0 or 1, so if the current value is not
-    // empty, use the label for 1, and if it's empty, use the label for 0.
-    return $this->operator . ' ' . $this->valueOptions[!empty($this->value)];
   }

This change does not correct. Prior to this change this method would always return a string now it does not. I think this should be:

  public function adminSummary() {
    if ($this->isAGroup()) {
      return $this->t('grouped');
    }
    if (!empty($this->options['exposed'])) {
      return $this->t('exposed');
    }
    if (empty($this->valueOptions)) {
      $this->getValueOptions();
    }
    if (in_array($this->operator, $this->operatorValues(1), TRUE)) {
      $this->getValueOptions();
      // Now that we have the valid options for this filter, just return the
      // human-readable label based on the current value.  The valueOptions
      // array is keyed with either 0 or 1, so if the current value is not
      // empty, use the label for 1, and if it's empty, use the label for 0.
      return $this->operator . ' ' . $this->valueOptions[!empty($this->value)];
    }

    return $this->operator;
  }

Nice, feedback has been addressed, did some extra manual testing to check the admin label, and looks good

I tested this on Drupal 10.1.x, standard install. I added a boolean field to the Page content type and made three nodes. One with the boolean On, two where I did not touch the boolean field. I created a duplicate of the Content view, adding the boolean to the fields and the filters.

1. with Is empty (NULL) there are no nodes displayed - I expected two nodes here, the ones where I did not tick the boolean.
2. with Is not empty (NULL) all three nodes are displayed. - I expected 1 node here, the one where I ticked the boolean.

I guess the field value is either TRUE of FALSE. How does it become NULL? More importantly, will this confuse the user?

I then played with the filter. it worked, except when exposed.

If the filter is exposed and the operator is "is empty(NULL)' or "Is not empty (NULL)" and I go to my view, I get a Warning. I did not check the results.

Warning: Undefined array key "field_boolean_value" in Drupal\views\Plugin\views\filter\FilterPluginBase->acceptExposedInput() (line 1502 of core/modules/views/src/Plugin/views/filter/FilterPluginBase.php).

Drupal\views\Plugin\views\filter\FilterPluginBase->acceptExposedInput(Array) (Line: 188)
Drupal\views\Form\ViewsExposedForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object

Back to because of the warning.

The error comes out of the same pile of ifs as what we are looking at here #3259090: Exposed filter equality check works differently in PHP 8.0, that really needs some coverage :(

To reproduce the NULL values you can do two thing:
* Create some content, then add a new boolean field to it. These values will now be NULL until you save the content again
* Other option, create a View with an optional relationship to something that has a boolean field. In the rows that don't have the relationship the values will be NULL

* Other option, create a View with an optional relationship to something that has a boolean field. In the rows that don't have the relationship the values will be NULL

As Lendude mentions here this is a massive gap in the current boolean filter logic, take the following scenario:

I have a View that lists multiple bundles of the same entity type, one of those bundles has a boolean field. I want to be able to filter the view to only show records that don't have that field (all but one of the bundles), or have a false value for the field. This is currently unachievable.

To my mind this is the main use case we are solving here.

+1 for the patch in #9.

Managed to successfully use the patch to acheive the above use case. I used an OR filter group containing a = FALSE condition and a IS NULL condition. Worked perfectly, thanks!

+1 for the patch in #9.

It worked perfectly to provide new operator options "Is empty (NULL)" and "Is not empty (NOT NULL)" inside of the Views Filter Criteria section.

Re-rolled patch for Drupal 10.3

Doh! Of course the patch failed to apply for 10.1.

I picked up this instead of #3098560: Add 'Is empty (NULL)' and 'Is not empty (NOT NULL)' to field Filter Operators Options since this has working tests. Otherwise the "Proposed resolution" section seems rather identical with these two issues, calling for closing either of these or refining the issue summary.

I marked #3098560: Add 'Is empty (NULL)' and 'Is not empty (NOT NULL)' to field Filter Operators Options as PNMI for someone to confirm this ticket fixes the same issue, if not that issue should specify what didn't make it.

For this ticket

Ran the test-only feature

1) Drupal\Tests\views\Kernel\Handler\FilterBooleanOperatorTest::testEmptyFilterBooleanOperator
Failed asserting that actual size 6 matches expected size 1.
/builds/issue/drupal-3322402/core/modules/views/tests/src/Kernel/Handler/FilterBooleanOperatorTest.php:161
FAILURES!
Tests: 3, Assertions: 13, Failures: 1.

Show the test coverage.

Checking the issue summary, it appears complete with a matching solution to the MR.

Looking at the code I applied some small typehints for the new functions and the test.

I left dataSet and schemaDefinition as those are inherited and probably could be a standalone ticket for applying throughout the repo.

Rest appears to do as advertised.

Nice to see these small features still getting attention, I've needed this before on a similar project and had to patch in support for it.

Committed b6c0243 and pushed to 11.x. Thanks!

Not eligible for backport as it's a new feature, anything building on this has to be targetted at 11.1 and above only.

Sorry for posting to a closed thread, but I just came across this need and wanted to suggest a solution for the use case in #13.

You can configure two groups of AND filters and OR them. You just need to duplicate the conditions that apply to all bundles in both groups.

Group 1:
Bundle = X
AND
Condition 1
AND
Condition 2

OR

Group 2:
Bundle = Y
AND
Condition 1
AND
Condition 2
AND
Condition 3 (that only applies to Bundle Y)