Problem/Motivation

We've updated cspell a few times, but never checked if the words we're ignoring by using that tag, entered a dictionary since they were tagged to be ignored.

Also, let's check if the changes made in #3308419: Use all the included dictionaries with cspell, where we (going to) use all included libraries can lead to less cspell:ignore [word] tags.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#18 3308445-nr-bot.txt299.54 KBneeds-review-queue-bot

Issue fork drupal-3308445

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Add dictionaries to core/.cspell.json that are of use to us » [PP-1] Add dictionaries to core/.cspell.json that are of use to us
Status: Active » Postponed
Related issues: +#3306441: Update to the latest cspell version (6.8.1), +#3308419: Use all the included dictionaries with cspell

Let's wait until #3306441: Update to the latest cspell version (6.8.1) lands

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Add dictionaries to core/.cspell.json that are of use to us » [PP-1] Add dictionaries to core/.cspell.json that make our own Drupal dictionary smaller
spokje’s picture

spokje
Primary language Dutch
commented
Status: Postponed » Closed (outdated)
spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Add dictionaries to core/.cspell.json that make our own Drupal dictionary smaller » [PP-1] Check if cspell:ignore tags are still needed
Issue summary: View changes
Status: Closed (outdated) » Postponed

Repurposed issue.

quietone’s picture

quietone commented
Title: [PP-1] Check if cspell:ignore tags are still needed » Check if cspell:ignore tags are still needed
Status: Postponed » Active

No longer postponded

spokje’s picture

spokje
Primary language Dutch
commented
Title: Check if cspell:ignore tags are still needed » [PP-1] Check if cspell:ignore tags are still needed
Status: Active » Postponed

I think we will get a lot more words covered by dictionaries if we wait until #3308419: Use all the included dictionaries with cspell lands.
More covered words, means less exceptions with cspell:ignore [word].

So I think we postpone this issue on #3308419: Use all the included dictionaries with cspell, especially since the whole process of removing all ignore tags, recreate dictionary, check what's gone/still there, probably rinse, wash, repeat is rather time consuming.

If the above doesn't make sense, please feel free to un-postpone again.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned

longwave made their first commit to this issue’s fork.

longwave opened merge request !5369

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Removed all cspell:ignore lines with

rg -l cspell:ignore|xargs sed -i '/cspell:ignore/d'

Let's see what happens.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Check if cspell:ignore tags are still needed » Check if cspell:ignore tags are still needed
Status: Postponed » Needs review

Postponed issue was closed as won't fix so let's just make this active again.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I do wonder if we should enable the allowCompoundWords setting which would allow words like "objectindex", or maybe on a per-file basis?

Or, we can bikeshed over which ones should be added to the Drupal dictionary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

The results are in: https://git.drupalcode.org/project/drupal/-/jobs/321950

quietone’s picture

quietone commented
Status: Needs work » Needs review
Parent issue: » #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them
Related issues: +#3390959: Test for words in 'cspell:ignore' that can be removed

There is #3390959: Test for words in 'cspell:ignore' that can be removed which is adding a script to check that all words in a cspell:ignore line are still needed. I think this is a duplicate of that, or am I mistaken?

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3308445-nr-bot.txt299.54 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Closed (duplicate)

+1, wasn't following that other issue, closing this as duplicate.