Drupal 10 readiness meeting / 13 June 2022 [#3285462]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3285462`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

xjm	:wave: xjm, core release manager and Composer monkey
Ilcho Vuchkov (vuil)	ilcho vuchkov, bulgaria (eu)
Bruno Branco Bicudo	Bruno Bicudo, Brazil :wave:
hestenet (he/him)	Tim from the DA checking in :slightly_smiling_face:
Björn Brala (bbrala)	Hi, Björn. Updatebotter
Kristen Pol (she/her)	Kristen, California, catching up
larowlan	Lee, Australia, Catching up
longwave	Dave, UK, also catching up
quietone	Catching up as well
Spokje	Frank, almost on time...
dww	Derek @ TEN7

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

hestenet (he/him)	Maybe doesn't need to be a whole topic, but it looks like the June 12 project analysis run went successfully. (https://dispatcher.drupalci.org/job/project_analysis_d10/127/) (edited)
xjm	CKEditor 4 deprecation steps
xjm	Also status update on QuickEdit, Seven, Bartik, etc. deprecations maybe?

2️⃣ ALL of the deprecated APIs are now defined for Drupal 10 with Drupal 9.4.0-beta1!

Gábor Hojtsy (he/him)	This was not mentioned last week and was a side mention on the meeting the week before, so wanted to bring this up again prime time :smile:
Gábor Hojtsy (he/him)	https://twitter.com/xjmdrupal/status/1531356030357184516
xjm	There will be a few small exceptions, e.g. there are a couple libraries for CKEditor 4 and stuff in Media that we forgot to deprecate. But any exception like that will be a release note, and only for critical D10 blockers. Won't me more than a couple, I think.

3️⃣ Fresh data about Drupal 10 readiness shows 122 of the top 1k projects are Drupal 10 ready in dev and in the process of getting releases that are compatible!

Gábor Hojtsy (he/him)

These specifically are at https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=Re... :slightly_smiling_face:

4️⃣ Patches are now lined up for the project update bot to run

Gábor Hojtsy (he/him)	Sort of this was raised by @hestenet (he/him) :slightly_smiling_face: patches are under https://dispatcher.drupalci.org/job/project_analysis_d10/127/
Gábor Hojtsy (he/him)	Thanks to a lot of work recently by @Björn Brala (bbrala)
Gábor Hojtsy (he/him)	My spot-checking of the generated patches indicates they look as good as it gets.
Björn Brala (bbrala)	Yeah until new fixes get merged into rector. There is a few new ones in the new version that will run next Sunday.
Gábor Hojtsy (he/him)	Build 127 generated 4991 patches of which 500 include composer.json fixes as well thanks to recent fixes from @Björn Brala (bbrala)
Gábor Hojtsy (he/him)	@hestenet (he/him) I think the MR should be fine to merge now and run from there :slightly_smiling_face:
Gábor Hojtsy (he/him)	@tedbow I think a few sample live patches could be posted now from the bot :slightly_smiling_face:
Gábor Hojtsy (he/him)	We also posted https://www.drupal.org/blog/the-project-update-bot-is-being-refreshed-to... since the last weekend to prepare the community
tedbow	@Gábor Hojtsy (he/him) give me some project machine names and I will (edited)
Björn Brala (bbrala)	I wouldn't mind you using some of mine to test if you like
Gábor Hojtsy (he/him)	@tedbow git_deploy, potx and deprecation_status are good from mine, they have patches :slightly_smiling_face:
tedbow	ok. I am AFK will do in an hour or so
Björn Brala (bbrala)	If you want more, just ping me.
Gábor Hojtsy (he/him)	@tedbow bbrala has jsonapi_extras and twig_renderable which have patches :slightly_smiling_face:
Gábor Hojtsy (he/him)	thanks @tedbow
Björn Brala (bbrala)	And mappi_lane, wordproof, mailing_subscriber, mailing_subscriber_mailchimp, twig_renderable. All with patches.
Björn Brala (bbrala)	But that is by no means a request to do em all :wink:
Kristen Pol (she/her)	Just noticed that it takes a long time to load the Project Update Bot's d.o page... busy bot! :robot_face:https://www.drupal.org/u/project-update-bot
Björn Brala (bbrala)	hehehe
Björn Brala (bbrala)	is has had a lot of activity in the past xD
Kristen Pol (she/her)	Maybe needs a nap :sleeping:
Björn Brala (bbrala)	haha :smile:
Kristen Pol (she/her)	https://twitter.com/kristen_pol/status/1536431276558757889?s=20&t=4XXhAv...
Björn Brala (bbrala)	@Gábor Hojtsy (he/him), it does seem the bio of the update bot needs an update though
Gábor Hojtsy (he/him)	@Björn Brala (bbrala) good point, updated for Drupal 10 just now :slightly_smiling_face:
Björn Brala (bbrala)	:slightly_smiling_face:
larowlan	Great work!
tedbow	@Björn Brala (bbrala) @Gábor Hojtsy (he/him) I forgot to ask what branch of https://git.drupalcode.org/project/infrastructurecould I be using for the bot templates?still in the merge request branch?
tedbow	I guess I should do this one? https://git.drupalcode.org/issue/infrastructure-3279548/-/tree/3279548-d10
hestenet (he/him)	@mixologic ^^ Maybe we want to merge that into Main since it's now working - before tedbow kicks off the next round?
Gábor Hojtsy (he/him)	@tedbow in the MR for now
tedbow	@Gábor Hojtsy (he/him) @Björn Brala (bbrala) Ok here are the issues for the project listed above
tedbow	https://www.drupal.org/project/issues/search?projects=&project_issue_fol...
Björn Brala (bbrala)	Awesome!
Gábor Hojtsy (he/him)	@tedbow looks good to me, I noticed #3285603: Automated Drupal 10 compatibility fixes for deprecation_status via email notification too :slightly_smiling_face:
tedbow	side note: we should have profile picture for the bot
Gábor Hojtsy (he/him)	https://unsplash.com/photos/pi9W2dWDdak? :smile:
tedbow	that looks good to me!
Gábor Hojtsy (he/him)	Here is a quick custom one :smile: better?
tedbow	that would work too
jkdev	Wow. great picture. But what is the blue splash behind.My guess it look odd when displayed small.
Gábor Hojtsy (he/him)	ok a more traditional shape :smile:
Gábor Hojtsy (he/him)	updated the profile :smile:
Björn Brala (bbrala)	Hmm
Björn Brala (bbrala)	Debug infoBot run #127This patch was created using these packages:mglaman/phpstan-drupal: 1.1.9palantirnet/drupal-rector: 0.12.0Is that correct? I don't think so. I'll check in a minuten.
Björn Brala (bbrala)	Minute
Gábor Hojtsy (he/him)	@tedbow where does the bot collect this info?
Björn Brala (bbrala)	Hmm, pc at home is off, cant check :x
Björn Brala (bbrala)	But it feels off, i think even the old version was higher than 0.12.0
Björn Brala (bbrala)	and this will be updated from now on also, so would be good to have correct info available
tedbow	:hankey: This run didn't actually download artifacts of run 127(there is setting to disable the download, if it is already downloaded.)re the packages info. That is read from a file drupal-composer.lock.json that is produced in the run. but since it didn't download the artifacts it was probably from the previous run which was I think 125
Gábor Hojtsy (he/him)	Based on run 127, 0.12.0 was the drupal-rector version indeed and 1.1.9 of phpstan-drupal, so those were not incorrect (edited)
tedbow	let me run it again and post to the dev site. with the above projects
Björn Brala (bbrala)	Hmm, sorry then. So technically next sunday it would read something more recent.
Björn Brala (bbrala)	image.png
tedbow	is the plan to run it next Sunday?
Björn Brala (bbrala)	It will run next sunday again yeah
Björn Brala (bbrala)	We could pull it up if ask tim nicely.
tedbow	oh the patch generator. ok
Björn Brala (bbrala)	yeah
Gábor Hojtsy (he/him)	yeah this runs weekly :smile:
Gábor Hojtsy (he/him)	@Björn Brala (bbrala) recently updated the MR to update the components instead of hardcoding them to known working ones
Björn Brala (bbrala)	Yeah, it will update composer/drupal-rector/upgrade_status
Gábor Hojtsy (he/him)	So I think this run is fine to get going and we say in the comments that we’ll improve it, so unless we know this does something wrong (vs. not as perfect as it could be ATM), then I think its fine to post the patches :smile:
tedbow	and using run 127 works? or should we wait for another run?
Gábor Hojtsy (he/him)	It should work IMHO :slightly_smiling_face:
Gábor Hojtsy (he/him)	I spot-checked the patches it generated and those looked fine
tedbow	It is been a long time since we ran the bot where it was going to produce thousands of issues. I can't remember if tried to do that in "off" hours. Anybody have an opinion?
Gábor Hojtsy (he/him)	@drumm or @hestenet (he/him) would be able to tell you :)
drumm	Would rather have it during the day so we’re awake if something goes off.
tedbow	sounds good. I guess I will start it tomorrow morning then so I am around for the entire run
drumm	Maybe slightly late morning so my west coast coworkers could be awake. I have a framing inspection tomorrow, so I’m probably going to be at my house waiting for 3 days.
tedbow	sounds good
tedbow	I am the waiting for 3 days doesn't sound good
tedbow	@drumm is there anyone I should ping at the DA when or before I start?
drumm	@hestenet (he/him) I suppose
tedbow	k
drumm	I don’t expect any problems, just so we’re aware.
hestenet (he/him)	:thumbsup::skin-tone-3:

5️⃣ CKEditor 4 deprecation steps

Gábor Hojtsy (he/him)	Raised by @xjm
xjm	The meta for this is #3270437: [meta] Tasks to deprecate the CKEditor 4 module
xjm	@wimleers (he/him) and @lauriii are doing some research into the media integration stuff later this week, but we could use help with all the other issues too
larowlan	Hoping to give the styles combo patch another manual test on Friday

6️⃣ Seven and Bartik deprecation

Gábor Hojtsy (he/him)	Raised by @xjm
xjm	I found #3278212: [Meta] Tasks to deprecate Seven -- would love to know how it's going and if folks can help with these :slightly_smiling_face:
xjm	Oh I also heard the Claro and Olivero folks have a new regular meeting in #frontend together -- if anyone here is also going to join that, please do bring these two metas up with them. :slightly_smiling_face:
Kristen Pol (she/her)	I hadn't heard about this frontend meeting so I asked for it to be added to the core calendar: https://drupal.slack.com/archives/C0D5GJZ8B/p1655149160870109?thread_ts=...
catch	Most of the activity is on #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro and the sub-issues. Lots of progress, lots still to do.
lauriii	We need to make decision on #3285049: Decide what to do about CKEditor styles in core themes
catch	For themes moving out of core I'd just leave it in.For Olivero/Claro that is harder - just drop it when ckeditor4 is removed?
lauriii	That could be one solution
lauriii	Seems worth posting on the issue

7️⃣ QuickEditor deprecation

Gábor Hojtsy (he/him)	Raised by @xjm
xjm	#3228986: [Meta] Tasks to deprecate Quick Edit is the meta; what's next?
Björn Brala (bbrala)	Looks kinda close actually...
larowlan	Feel free to ping me for reviews here
larowlan	Pretty time poor atm, but keen on this
catch	#3264633: Remove \Drupal\layout_builder\QuickEditIntegration and refactor it so that quickedit contrib provides the integration with layout builder needs review.
catch	#3267258: Remove Quick Edit support from editor.module needs some help with a test failure.
catch	#3265492: Fix inaccuracies in quickedit help topic (after the split from settings_tray) needs commit it looks like.
catch	As far as I know those are all the outstanding issues now.
dww	I’ve been particularly slammed recently, partly $dayJob stuff, but also because I finally produced & performed some live concerts again over the weekend, which has been taking up any available cycles. The shows are over, and I’ve got a relatively lighter load at work this week, so I’m going to try to move all these forward again as best I can...P.s. happy to see the help topic fix landed. Thanks catch for the commit.