Drupal 10 readiness meeting / 6 June 2022 [#3284085]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3284085`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

hestenet (he/him)	Tim from the DA stopping by :slightly_smiling_face:
Kristen Pol (she/her)	Kristen, California :wave:
Björn Brala (bbrala)	Lurking
Tinto	Hello from Amsterdam, The Netherlands :raising_hand:
andypost	Andy, still Ukraine
shaal	Ofer Shaal, Boca Raton, Florida :blob_wave: (edited)
Ilcho Vuchkov (vuil)	Ilcho Vuchkov, Bulgaria (EU).
el7cosmos	Hi, Abi, Indonesia
xjm	xjm, catching up after TFA disaster
heddn	heddn, just checking the backlog and interested in the D10 readiness and project bot. Plus AVIF image support topic.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

Kristen Pol (she/her)	What is the best way to find d10readiness issues that are top priority?
andypost	AVIF image support, should it go 10.0 or 9.5 #3202016: Let GDToolkit support AVIF image format

2️⃣ Drupal 10 contrib readiness data is up to date again

Gábor Hojtsy (he/him)	Thanks @Björn Brala (bbrala) and @mixologic for debugging :slightly_smiling_face:
Gábor Hojtsy (he/him)	See https://dev.acquia.com/drupal10/deprecation_status/projects for results
Kristen Pol (she/her)	Very vibrant colors!
Kristen Pol (she/her)	https://twitter.com/kristen_pol/status/1533874675540848640?s=20&t=Q_z_-L...
Kristen Pol (she/her)	One minor thing is the 43.x% is cut off on Chrome and resizing my browser didn't help
Gábor Hojtsy (he/him)	That does not happen to me although I’ve seen it happen before.
Kristen Pol (she/her)	It's due to browser size... I'm on a 13"... I resized the window and then reloaded and then it shows up
Kristen Pol (she/her)	I can get it to not show anything if I resize and reload
Gábor Hojtsy (he/him)	Hm, its a hundred or so lines of JS code all within the page that generates it, would be great to get help fixing it up :slightly_smiling_face:
Kristen Pol (she/her)	JS isn't my strongest skill :slightly_smiling_face:
Gábor Hojtsy (he/him)	Mine neither, hence the imperfect result :smile:
Kristen Pol (she/her)	It's almost there! It looks pretty nice :tada:
FeyP	Hey, I can just enter my user name and get an overview of all my deprecated code. I think this is a new filter? Nice feature! Right now, it doesn't look too bad for my modules, 62% are just info.yml changes, but I guess we're not quite done deprecating things yet...
FeyP	I notice that one project that I co-maintain doesn't appear in the data set. It's not that important, since there is no release yet. Then again, maybe that's why it's not included in the first place? That would make sense.
Gábor Hojtsy (he/him)	@FeyP yes the maintainer filter is new :) https://dev.acquia.com/blog/new-drupal-10-readiness-dashboard-devacquiacom
FeyP	I also like the new Make tagged release available step. I think it is a good idea to track this.I wonder how easy it would be to create periodic snapshots of certain data points from the dashboard so that we might be able to generate a curve tracking changes over time? I'm curious how fast contrib updates, when the majority of the work is done and if there are maybe certain classes of deprecations that take longer to fix than others. Don't know if the additional insight provided by something like this would warrant the extra work, though.
Gábor Hojtsy (he/him)	@FeyP interesting you say that, did you check out the charts tab? :wink:
FeyP	Whoops! Obviously, I didn't :slightly_smiling_face: Great we already have that, I'll keep an eye on it.
Gábor Hojtsy (he/him)	We have the historic data of each successful run we process (ideally one data point a week), so we can do more granular data mining later as well if someone has the time/interest to do that :slightly_smiling_face:
heddn	@Gábor Hojtsy (he/him) there seems to be some oddness with the data. It says 6.0 (which I know is d10 compatible)but then when I click the link, all the data is for 5.0:
heddn	and even test coverage to back it up:
heddn	Those projects have 2 release. But https://dev.acquia.com/drupal10/deprecation_status/projects/migrate_sour... only has one release. and it has a tagged release that supports ^9.1\|^10
heddn	image.png
heddn	image.png
Björn Brala (bbrala)	Interesting, wonder if it is a ommission of the source projects or not, very helpfull that you have some examples :+1:
Gábor Hojtsy (he/him)	@heddn the runner picks up both 5.x and 6.0.x of migrate_plus, and they indeed have different results; I don’t know how are they showing up as two different versions though as the summary table and the individual data comes from the same list :open_mouth:
heddn	@Gábor Hojtsy (he/him) migrate_source_csv only has one release and it also supports D10. :confused:
heddn	I tended to do >=9.1. is that breaking some regex?
Gábor Hojtsy (he/him)	Ah, the migrate_plus problem is Drupal caching more than is should. It shows up for me as 6.x properly logged in.
Gábor Hojtsy (he/him)	The migrate_source_csv is some weirdness with the data because I am not finding the same results in dataset #125 as its in the summary.
Gábor Hojtsy (he/him)	phpstan-results/migrate_source_csv.3.x-dev.upgrade_status.pre_rector.xml in the #125 dataset is<?xml version="1.0"?>
heddn	migrate_tools and migrate upgrade also suffers similar situation to migrate plus. i just didn't mention them. maybe they are caching too?
Gábor Hojtsy (he/him)	I don’t have more time today to look into this, but put todo items for tomorrow, thanks for noting @heddn
Gábor Hojtsy (he/him)	@heddn the caching problem is to be solved here :slightly_smiling_face: Let’s say the caching settings I made were quite careless here… the session cache context does not help in forms showing different data based on source refreshed elsewhere… #3284809: Use a proper cache tag instead of trying to not cache things or cache them improperly
Gábor Hojtsy (he/him)	The categorization of projects as “only info” and “not Drupal 10 compatible” is more complicated. This is currently processed with a simple PHP script which makes wrong assumptions and does not have complete semver parsing for sure.
Gábor Hojtsy (he/him)	Working on refactoring this, its quite an undertaking :open_mouth: But parsing with Semver::satisfies() identifies 451 Drupal 10 ready projects as opposed to the simple regex we had before that identified 409
Gábor Hojtsy (he/him)	so that will help
Björn Brala (bbrala)	Lovely :slightly_smiling_face:
Gábor Hojtsy (he/him)	there you go @heddn, decided to cut some corners in refactoring this to be ready sooner :smile: added the fixed dataset to the site now: https://dev.acquia.com/drupal10/deprecation_status/projects?names=migrat... (the caching bug will still apply, so individual project page may not yet be showing the result)
heddn	@Gábor Hojtsy (he/him)++ Nice!
heddn	image.png
Gábor Hojtsy (he/him)	It now uses composer/semver itself rather than a dumb regex I made up earlier :)
Björn Brala (bbrala)	^^ regex's are the bane of our existence.
heddn	@Björn Brala (bbrala) @Gábor Hojtsy (he/him) still some render cache issues. See https://drupal.slack.com/archives/C226VLXBP/p1654785270572759?thread_ts=...
Gábor Hojtsy (he/him)	Yeah

3️⃣ What is the best way to find Drupal 10 readiness core issues that are top priority? (edited)

Gábor Hojtsy (he/him)	Raised by @Kristen Pol (she/her)
Gábor Hojtsy (he/him)	I updated it to say “core” because I think that is what you meant? (edited)
Gábor Hojtsy (he/him)	#3118149: [meta] Requirements for tagging Drupal 10.0.0-beta1 has the key issues that have a 3 month deadline now
Kristen Pol (she/her)	Yes, core issues, thanks :slightly_smiling_face:
Gábor Hojtsy (he/him)	I think the removal of deprecated APIs stalled a bit recently, that would be great to pick up for example. That should be relatively simple compared to some of the more complex ones.
Gábor Hojtsy (he/him)	So that would be #3179048: [meta] Remove dead code/unneeded compatibility layers now that PHP 8.1 is required
Gábor Hojtsy (he/him)	The other category is 3rd party compatibility, specifically Symfony 6.1 have been released but we are not yet compatible: #3275864: Update to Symfony 6.1.1
Kristen Pol (she/her)	Thanks!
Kristen Pol (she/her)	https://twitter.com/kristen_pol/status/1533875830954176514?s=20&t=Q_z_-L...
Kristen Pol (she/her)	(I also responded to that ^ with those 3 specific issues)
Gábor Hojtsy (he/him)	Thanks
catch	Symfony 6.1 we now just need to wait for 6.1.1, no known blocking core issues left.
Gábor Hojtsy (he/him)	Marked the SF 6.1 issue postponed.
Gábor Hojtsy (he/him)	@catch any other key issues people should be looking at?
catch	There are issues blocking ckeditor4 deprecation whuch can be worked on now and are a lot more accessible than ckeditor5 issues.
catch	#3270437: [meta] Tasks to deprecate the CKEditor 4 module
catch	Also bartik/seven deprecation prep: #3278124: Convert various tests that use bartik/seven to olivero/claro
xjm	+1 for the above; I would suggest working on the issues for deprecating CKEditor, Bartik, and Seven.

4️⃣ PHP 8.2 compatibitlity

Gábor Hojtsy (he/him)	PHP 8.2 is not yet even in alpha, but folks have been identifying problems under #3283358: [META] Make Drupal 9/10 compatible with PHP 8.2
Gábor Hojtsy (he/him)	last week we agreed with the DA that an instance of a PHP 8.2 alpha will be made available on the testbot when that is out, one instance of a PHP 8.2 beta will be there when it is out and one instance of an RC will be available when it is out
Gábor Hojtsy (he/him)	in the meantime, local testing could help identify blocking issues
andypost	btw This week there will be 4 PHP releases) 8.2.0-alpha1 including
Gábor Hojtsy (he/him)	Woot :slightly_smiling_face: the testbot issue is at #3283449: Create a DrupalCI Environment for PHP 8.2
andypost	https://www.php.net/archive/2022.php#2022-06-09-3First alpha released

5️⃣ Project update bot

Gábor Hojtsy (he/him)	The past two weeks @Björn Brala (bbrala) worked on this quite a bit with a little involvement from me :slightly_smiling_face: he did a fantastic job :slightly_smiling_face: I did not check the most recent updates but it looks real close
Gábor Hojtsy (he/him)	any way I can help there? :slightly_smiling_face:
Björn Brala (bbrala)	Only thing left is the composer.json stuff, then i think we are done for now. At least with the bot.
Björn Brala (bbrala)	Started to have a look and got distracted hehe, did commit a simple 'run it in docker' script.
Björn Brala (bbrala)	I should be able to get the composer.json stuff done this week. Its not hard hopefully. Could use your feedback at that time.
Gábor Hojtsy (he/him)	ok, I’ll keep an eye, thanks for your continued work on this :slightly_smiling_face:

6️⃣ Heads up about drrupal-rector 0.12.5 coming up, will include breaking changes

Gábor Hojtsy (he/him)	@mglaman sent a message to make sure this ends up in the meeting
Gábor Hojtsy (he/him)	https://github.com/palantirnet/drupal-rector is currently at 0.12.4
Gábor Hojtsy (he/him)	a drupal-rector update will require breaking changes to the config file
Gábor Hojtsy (he/him)	The fix will be to re-do: cp vendor/palantirnet/drupal-rector/rector.php .
Gábor Hojtsy (he/him)	(and see if you need to readjust any configuration settings)
mglaman	I should be able to work on this this week
mglaman	My son's baseball coach got a new job, and needs me to take over. Which means my day ends a little bit earlier. And he has a game on Wednesday. but I should be able to grab this one, our conflicts are getting easier
mglaman	cc @agentrickard I dunno if Palantir wants to prep a blog post to be queued until closer to the release? like after PR raised and before release cut explaining the pending update, and for folks to pin at current stable release?
Björn Brala (bbrala)	Hmm, if you remember, ping me pls. We got a rector.php on the updatebot which would need an update then :x
agentrickard	@mglaman that’s a good idea

7️⃣ AVIF image support, which Drupal version it should target

Gábor Hojtsy (he/him)	Raised by @andypost
Gábor Hojtsy (he/him)	#3202016: Let GDToolkit support AVIF image format
Gábor Hojtsy (he/him)	I believe new features go to 10.1 now
andypost	As 10.0 depends on PHP 8.1 (the version where support was added/fixed) and the format is much better then WEBP I think this needs RM opinion
andypost	The format giving serious size/quality effect and I think it should be promoted to 10.0 (edited)
Gábor Hojtsy (he/him)	@catch would be able to provide RM feedback
catch	hmm if that particular one was also possible to get into 9.5, I would say it could go in because it's borderline task/feature for me. 10.0.x-only small features probably needs a bit more discussion.
xjm	The main considerations are (1) How disruptive is the change? (2) Does it require deprecations? (3) Is it a big new whole entire feature?
xjm	If the answers are "Not very, no, no" then I think it's OK in 9.5 (edited)
xjm	We can also open 10.1.x for development whenever we want at the cost of committer annoyance
xjm	(I do think a couple months of focusing on D10 is healthy though)
catch	With this one it's an extra plugin and the only visual change is an extra option in a select list. The issue with 9.5 is it won't work on PHP < 8.1 so has to be 10.x
catch	Given all that I would be ok with making an exception to 9.5/10.0 parity and adding to 10.0.x, especially since it doesn't provide any new API either. The worst that could happen is a module or profile including it in default config for an image style and breaking 9.4/9.5 compatibility.
xjm	Hmm
catch	But if not only option is 10.1
xjm	Yeah it's kinda in a weird space between feature/API addition and PHP 8.1 compatibility/enhancement
xjm	We already allow improvements in D10 to remove code paths that depend on old PHP versions, and I think we would allow internal cleanups to rely on new PHP 8.1 features as well. So that's probably OK. However, let's tag it for RM review so we can look at it one more time before commit just to ensure there's nothing hinky in breaking the branch parity when we do.
xjm	I'll comment
catch	Realistically it'll be hard for sites to use it until all the browsers support it. It's bad enough with webp on old Mac OS versions. But it's good to have it available.
xjm	#3202016: Let GDToolkit support AVIF image format#comment-14549186
heddn	I know that Google is very interested in seeing things like ^ land in core to help with core web vitals. So a +1 from me if this is a trivial addition
catch	btw I re-opened #3213491: Add fallback format support to responsive images after previously closing it due to webp support being (nearly) universal, avif shows it'd probably be useful to add as a generic feature.
andypost	Also there's broader issue #3116611: Add a requirements check for GD support of allowed image types