Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

CommentFileSizeAuthor
#2 3272537-2.patch4.02 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Priority: Normal » Major
Status: Active » Needs review
Issue tags: +Drupal 10
StatusFileSize
new 3272537-2.patch4.02 KB

This is about as trivial as they get. These tests didn't actually need to be changed at all outside of changing classy to stark.I tried to add some value by using the new WebAssert methods for asserting status messages where applicable.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Assigned: danflanagan8 » Unassigned
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Code looks good to me

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3272537-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Rrrrrrrandom JStest failure, back to RTBC per #4.

  • catch committed 823a7af on 10.0.x 
    Issue #3272537 by danflanagan8: Help and Help Topics tests should not...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

  • catch committed a30b87a on 9.4.x 
    Issue #3272537 by danflanagan8: Help and Help Topics tests should not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.