Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Follow-up from #3261486: Remove core updates added prior to 9.3.0 and adjust test coverage.
Does it make sense to add drupal-9.3.0.bare.standard.php.gz and drupal-9.3.0.filled.standard.php.gz to Drupal 9.3 and 9.4?
contrib modules with update tests that try to add Drupal 10 support can reference those files, instead of adding a check if the current Drupal version is Drupal 10, use drupal-9.3.0.bare.standard.php.gz. Else, use drupal-9.0.0.bare.standard.php.gz
Proposed resolution
Copy drupal-9.3.0.bare.standard.php.gz and drupal-9.3.0.filled.standard.php.gz from the Drupal 10 branch to Drupal 9.4 so contrib modules can use those dumps for their update tests in both Drupal versions.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3263886-2.patch | 729.23 KB | jeroent |
Comments
Comment #2
jeroentComment #3
jeroentComment #4
catchThis is a good idea. Is it worth adding a 9.3 to 9.4+ update test while we're in here?
Comment #5
spokjeJust wanting to point out that in issues where we move Core modules from Core to Contrib in D10, changes in both the fixtures
drupal-9.3.0.bare.standard.php.gzanddrupal-9.3.0.filled.standard.php.gzare needed.For example, #3227033: Remove Quick Edit from core changes both and #3049857: Remove HAL module from core and create a contrib project for it will change
drupal-9.3.0.filled.standard.php.gzat some point.This would mean that those changes would probably need to be backported also to 9.4.x.
We _could_ postpone this on the release of D10.0.0-beta1 at which point all removals should be done and the fixtures should be stable for a long time, or we can trust in our Core Committers to remember to backport any changes to those fixtures every time they occur.
Comment #6
catchTheoretically it ought to work if the 9.3.0 fixture stays the same in 9.4.x, since we'd only be testing updates added to 9.4.x which still has those modules - however it could be confusing for backports.
Comment #7
catchBumping to critical, since as pointed out in #3261486: Remove core updates added prior to 9.3.0 and adjust test coverage this makes backports of new updates very difficult.
Comment #8
daffie commentedLooks good to me.
Comment #9
dwwOkay, great. I wasn’t sure if we had a separate issue for this. Happy to fix it separately
Thanks!
Comment #11
catchCommitted/pushed to 9.4.x and cherry-picked to 9.3.x, thanks!
Comment #13
dwwSweet, thanks! Adding credit for @daffie's review and for myself (since I created / uploaded an identical patch to #3261486 at xjm's request).
Cheers,
-Derek