Problem/Motivation

\Drupal\Core\TypedData\Validation\ExecutionContext implements Symfony's ExecutionContextInterface and was originally copied from Symfony 2. Symfony deprecated several methods and removed them in Symfony 3.

Steps to reproduce

Proposed resolution

Remove methods that don't belong to the interface any more.
Clean up code that deals with the legacy validator API that is no longer used.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3258407-6.patch2.54 KBlongwave
#5 3258407-nr-bot.txt143 bytesneeds-review-queue-bot
#2 3258407-2.patch2.44 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3258407-2.patch2.44 KB

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3258407-nr-bot.txt143 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3258407-6.patch2.54 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3258407-6.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Code changes only removes methods that are currently throwing LogicExceptions.

RTBC, test failure is a random JS one.

  • catch committed 724c5521 on 10.1.x 
    Issue #3258407 by longwave: Remove unused Symfony 2.x methods from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks good. The LogicException for extra arguments would help someone calling with the old API, but I don't think we need to keep that into 10.1 (or that it would be common).

Committed 724c552 and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.