Problem/Motivation

In UpdateSemverContribTest::setProjectInstalledVersion(), we do this to set the installed version of Drupal core:

      'drupal' => [
        'project' => 'drupal',
        'version' => '8.0.0',
        'hidden' => FALSE,
      ],

This does not match the logic in update_test_system_info_alter(), which expects an #all key to set the core version (as seen in UpdateSemverCoreTest::setProjectInstalledVersion()).

So basically UpdateSemverContribTest is wrong here, and possibly passing falsely.

Steps to reproduce

N/A

Proposed resolution

Use the #all key to change the core version in UpdateSemverContribTest.

Remaining tasks

Post a test-only merge request which makes the change, just to see if any tests break, and which ones.

If no tests break, it means our coverage is lacking and we need to add some. If tests do break, fix them. This is what should be done in the second merge request.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#10 3253149-nr-bot.txt150 bytesneeds-review-queue-bot

Issue fork drupal-3253149

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Crediting @tedbow, who found this issue and discussed the approach with me.

tedbow’s picture

Status: Active » Needs work

@phenaproxima thanks for making the issue. I am actually surprised nothing failed!

tedbow’s picture

Status: Needs work » Needs review

the fail is expected in the branch

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new150 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

I think this has been resolved by #3348234: Create test trait to set update_test module settings. Therefor I am closing this as outdated. If that is incorrect re-open the issue and comment.

Thanks.