Problem/Motivation
In UpdateSemverContribTest::setProjectInstalledVersion(), we do this to set the installed version of Drupal core:
'drupal' => [
'project' => 'drupal',
'version' => '8.0.0',
'hidden' => FALSE,
],
This does not match the logic in update_test_system_info_alter(), which expects an #all key to set the core version (as seen in UpdateSemverCoreTest::setProjectInstalledVersion()).
So basically UpdateSemverContribTest is wrong here, and possibly passing falsely.
Steps to reproduce
N/A
Proposed resolution
Use the #all key to change the core version in UpdateSemverContribTest.
Remaining tasks
Post a test-only merge request which makes the change, just to see if any tests break, and which ones.
If no tests break, it means our coverage is lacking and we need to add some. If tests do break, fix them. This is what should be done in the second merge request.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3253149-nr-bot.txt | 150 bytes | needs-review-queue-bot |
Issue fork drupal-3253149
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
phenaproximaCrediting @tedbow, who found this issue and discussed the approach with me.
Comment #5
tedbow@phenaproxima thanks for making the issue. I am actually surprised nothing failed!
Comment #7
tedbowthe fail is expected in the branch
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #12
quietone commentedI think this has been resolved by #3348234: Create test trait to set update_test module settings. Therefor I am closing this as outdated. If that is incorrect re-open the issue and comment.
Thanks.