Remove empty and deprecated IE11 polyfill library stub entries in 11.0.0

Initial two patches.
The first one without yarn build:css

+++ b/core/core.libraries.yml
@@ -22,16 +22,6 @@ ckeditor:
-css.escape:

@@ -148,12 +138,6 @@ drupal.autocomplete:
-drupal.array.find:

@@ -292,18 +276,6 @@ drupal.dropbutton:
-drupal.element.closest:
...
-drupal.element.matches:

@@ -340,16 +312,6 @@ drupal.message:
-drupal.nodelist.foreach:
...
-drupal.object.assign:

@@ -442,15 +404,6 @@ drupal.vertical-tabs:
-es6-promise:

@@ -770,18 +722,6 @@ once:
-picturefill:

Do we need to deprecate these core libraries in 9.x for removal in 10?

Adding some additional polyfills that can be removed.

The associated js packages needs to be removed from package.json and core/scripts/js/assets.js as well.

Can we remove the `postcss-custom-properties` plugin as well?

postcss-calc

I think it has nothing to do with IE 11.

Moved to gitlab.
10.0.x branch was widely updated for the past 4 months, so need to review again changes in #2 and fix remaining things

Ready for review

umm, we're removing without deprecating first. Probably need a green light from the release managers.

looking at contrib usage, it's very low but I think we should still deprecate first in 9.4 before removing those libs. A followup for the deprecation should be opened.

Postponing this one, we should have the deprecations before actually removing the files.

A bit too quick with the postponing

Added #3263823: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0

Any chance to have a D10 contrib project that holds the dropped polyfills?
Edit: nevermind. Checked for my project and this is a minor thing that I can take care on my own.

FWIW I think IE is the only remaining user of core/drupal.date. See #3256549: Deprecate core/drupal.date asset library in 9.4.0

Created a Tugboat preview of this at https://3238501-remove-polyfills-faf2jeeweess1xalhfhpahdzqo0yct0k.tugboa....

Note this is based off the Olivero tugboat db, so Olivero's and Claro are set to be the default themes. That being said, this should do well for testing.

Oops, wrong issue.

Are we gonna keep the core/misc/polyfills/array.includes.js polyfill? Looking at the MR I haven't found the file being removed.

Discussed this with @lauriii, summarised in #3263823-10: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0. Our existing deprecation policy just does not work for polyfills, because they aren't really an API as such and there is not really a replacement or anything for people to use.

Because (luckily) missing library dependencies doesn't trigger a warning, the least-disruptive option is actually to just remove these outright in 10.x without a 9.x deprecation.

Yet another option would be empty, deprecated, libraries in 10.x for removal in 11.x, but that would contradict our attempt to not add 10-for-11 deprecations in 10.0.0.

Given all that, I think we need to update the bc policy with a specific section for polyfills, but also should just go ahead and remove the definitions here with a change record.

added release note text

Overall looks good, few details

The picturefill package needs to be removed from package.json and vendor-update script. As-is vendor update crashes because it tries to copy files that do not exist in node_modules

This MR touches postcss.config.js - that is actually unused so #3086931: Remove unused postcss.config.js would be good to get in as well.

So here's what I did:

- Updated MR with the latest from 10.0.x.
- As recommended by nod_ in #28 I removed picturefill from core/package.json.
- Removed stuff from core/scripts/js/vendor-update.js that's deleted in this issue. Ran it locally and it doesn't crash.
- Removed core\modules\responsive_image\js\responsive_image.ajax.es6.js and it's js counterpart, since it was only adding the now removed picturefill.
- Removed core\modules\responsive_image\responsive_image.libraries.yml since that was only adding the now removed responsive_image.ajax.es6.js.
- Removed comment and help references from core\modules\responsive_image\responsive_image.module regarding picturefill.
- Ran yarn install which made changes in core/yarn.lock.
- Since a lot of files were deleted, I recreated core/misc/cspell/dictionary.txt.
- Needed to do a yarn run build:css -- --file themes/olivero/css/base/variables.pcss.css to pass CS checks.

Haven't looked closely yet but this is looking good to me

Patch is looking good to me too, haven't tested enough to RTBC yet though. One thing I spotted:

    // Prepare the fallback image. We use the src attribute, which might cause
    // double downloads in browsers that don't support the picture tag.

If everything supports <picture> now, can we remove the fallback image in a followup?

If everything supports
now, can we remove the fallback image in a followup?

I would say yes.

Follow-up issue for removal of the fallback image functionality: #3292249: [PP-1] Remove fallback image from responsive_image module

In addition to reviewing the patch, I took Drupal on a test drive with the console open to see if there were any errors. I paid special attention to the admin interfaces that did more heavy JS stuff (media, views, tabledrag pages, etc). I performed this on Chrome, Firefox, and Safari.

I couldn't break anything (well anything new!), and the patch looks good!

Got excited about this and committed it, but then re-read the whole issue and #3263823: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0 and reverted again.

We need to do #3263823: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0 first, so marking postponed. I unpostponed in #3238501-26: Remove empty and deprecated IE11 polyfill library stub entries in 11.0.0 when marking the other issue duplicate, but when we went through the whole thing again and un-duplicated it, and that discussion never got back here.

Also see all the discussion in #3263823-10: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0 to #3263823-19: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0 - we ended up deciding to empty out the libraries in 10.0.x and deprecate them in 10.0.x for removal in 11.0.x

Let's get the other issue finished first, and this will end up being an 11.0.x issue once there's a branch open.

btw about 95% of the patch here is usable in that issue, the only difference should be leaving empty, deprecated stubs in core.libraries.yml, but all the code removal and usage removal will be 100% the same.

Blocker #3263823: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0 is in, also swapping to #3295574: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch as parent and lowering priority to normal

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

I don't think this is the last IE reference we have in core, but one less is always good, even if it's just the library remnants.

Committed 563e61a and pushed to 11.x. Thanks!