Problem/Motivation

The README for the Composer Scaffold plugin uses drupal/core as an example allowed-package. This is a poor example, because drupal/core is implicitly allowed and explicitly listing it has no effect. Using drupal/core as an example allowed-package misleads people into thinking that it has to be explicitly listed.

Proposed resolution

Either clearly state in the examples that drupal/core is implicitly allowed, or choose a different example package

Issue fork drupal-3221748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Dane Powell created an issue. See original summary.

danepowell’s picture

Issue summary: View changes

danepowell’s picture

Status: Active » Needs review
cilefen’s picture

Issue tags: +Documentation
joachim’s picture

Status: Needs review » Reviewed & tested by the community

LGTM.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

I think there is a part of this change that's not correct. See merge request comment above

danepowell’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Needs work

The new text looks good but all lines in the README need to be wrapped at 80 characters.

danepowell’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, this looks good to me now.

alexpott’s picture

Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b0f50910d0 to 9.3.x and bfb29c2458 to 9.2.x. Thanks!

Backported to 9.2.x as this is documentation only.

  • alexpott committed b0f5091 on 9.3.x
    Issue #3221748 by Dane Powell, longwave, alexpott: drupal/core is...

  • alexpott committed bfb29c2 on 9.2.x
    Issue #3221748 by Dane Powell, longwave, alexpott: drupal/core is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.