Problem/Motivation

Possible cases where two blocks are moved to the same place at the same time, the ajax command will return an error and the wrong value will be stored in the layout store

Steps to reproduce

Try load testing

Proposed resolution

Add progress throbber to lock the page

CommentFileSizeAuthor
#3 interdiff-3217150-2_3.txt1.17 KBgauravvvv
#3 3217150-3.patch1.17 KBgauravvvv
layout-builder-prevent-twice-send-ajax-request.patch711 bytesoleh.tarasiuk

Issue fork drupal-3217150

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3217150-9.5.x Comparecompare
About issue forks

Comments

oleh.tarasiuk created an issue. See original summary.

oleh.tarasiuk’s picture

oleh.tarasiuk commented
Status: Active » Needs review
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3217150-3.patch1.17 KB
new interdiff-3217150-2_3.txt1.17 KB

Hi @oleh.tarasiuk, Don't write code directly into .js file. First, write in es6.js then compile it into .js file.

with following commands:
yarn run build:js

Re-rolled the patch. Attached interdiff for same.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Curious how are you able to trigger this?

Regardless it will need a test case.

rpayanm made their first commit to this issue’s fork.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

I can kind of replicate this on a fresh standard install with LB. I think it might be a general internet speed issue, I have to throttle my speed to get the occasional 500 to be thrown in the network tab if I perform multiple drags in quick succession. Unfortunately the patch doesn't resolve this.

Some more steps to replicate would be good here to track things down

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.