Problem/Motivation

The commit-code-check.sh script reports this spelling error: /var/www/html/core/scripts/create-subtheme.sh:64:31 - Unknown word (themekit) in #3214072: Provide an Olivero sub-theme creation tool (see "Custom Commands Failed" in #6).

It seems silly to change the name of the folder, so I can update the code, and satisfy the spellchecker. Is there another solution?

Comments

ressa created an issue. See original summary.

quietone’s picture

Category: Bug report » Support request
Issue tags: +Bug Smash Initiative

There are two options, only one of which is viable, a) add the word to core/misc/cspell/dictionary.txt commit-code-check or b) modify your code. The first option a) is very, very unlikely to get committed because we are working to remove words from that list not add them, see #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them.

On a personal level, I do appreciate that it can be a bit of a shock that the words we want to use are not allowed. In fact, some of my favorite things have been removed from core. Even with that I have come to appreciate the reduction in visual clutter when editing.

Changing to a support request because this isn't a bug.

Does that help?

ressa’s picture

Status: Active » Closed (works as designed)

Thanks a lot for the detailed answer @quietone, that was really helpful. I agree that including an automated spell check may seem confining at first, but it will catch a lot of spelling mistakes at a minimum of effort.

I am surprised to see that a word like "template" isn't included in the list, but maybe dictionary.txt only contains the special words allowed, and a normal dictionary is also used to control with? That would explain "themekit" not being allowed.

I renamed the folder to a certified word "subtheme", included in dictionary.txt and hope the tests pass :)

ressa’s picture

After renaming the folder, and some other minor changes all the tests now pass, so thanks again for all the help.