Problem/Motivation

In Symfony 5, symfony/event-dispatcher-contracts has been bumped from v1 to v2 and return types have been added to isPropagationStopped() and stopPropagation().

Steps to reproduce

See #3161889: [META] Symfony 6 compatibility

Proposed resolution

Add return type hints to Drupal\Core\File\Event\FileUploadSanitizeNameEvent as this is the only class in core that implements one of these methods.

Remaining tasks

User interface changes

API changes

Anything that subclass Drupal\Core\File\Event\FileUploadSanitizeNameEvent and further modifies the method will also need to add a typehint, but this seems very unlikely.

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3209239.patch665 byteslongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new665 bytes
longwave’s picture

Component: base system » file system

As this only affects one component.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

The class is new so should not have usages

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4feff07 and pushed to 9.2.x. Thanks!

  • catch committed 4feff07 on 9.2.x
    Issue #3209239 by longwave: [Symfony 5] Symfony\Contracts\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.