The document comment for Image::scaleDimensions() contains the following lines.

  /*
   * @return bool
   *   TRUE if $dimensions was modified, FALSE otherwise.
   *
   * @see image_scale()
   */

image_scale() is a Drupal 7 function that neither Drupal 8 nor Drupal 9 implements. The reference to that function should be removed, and the last lines of the document comment should be the following lines.

  /*
   * @return bool
   *   TRUE if $dimensions was modified, FALSE otherwise.
   */
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

Status: Active » Needs review
FileSize
567 bytes
longwave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-remove-function-reference-3166645-2.patch, failed testing. View results

  • larowlan committed e8ef145 on 9.1.x
    Issue #3166645 by kiamlaluno: The document comment for Image::...

  • larowlan committed 498fd74 on 9.0.x
    Issue #3166645 by kiamlaluno: The document comment for Image::...

  • larowlan committed 800d7f2 on 8.9.x
    Issue #3166645 by kiamlaluno: The document comment for Image::...
larowlan’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Needs work » Fixed
Issue tags: +Bug Smash Initiative

Committed e8ef145 and pushed to 9.1.x. Thanks!

As this is a bug, and the risk of disruption is approaching zero, backported to 9.0.x and 8.9.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.