t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.
Remove uses of t() in assertions has been done in the issue https://www.drupal.org/project/drupal/issues/3133726.
Remove all calls to t() wrapped in calls to drupalPostForm() will be done in the issue https://www.drupal.org/project/drupal/issues/3145005.
Replace all remaning occurance of t() calls with $this->t() in classes.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3164942-3.patch | 22.48 KB | akshay kashyap |
| #4 | interdiff.txt | 18.53 KB | akshay kashyap |
| #2 | 3164942-2.patch | 3.01 KB | siddhant.bhosale |
Comments
Comment #2
siddhant.bhosale commentedHi, I have uploaded the patch, Please review.
Comment #3
siddhant.bhosale commentedComment #4
akshay kashyap commentedI have applied #2 patch its working fine but some files you missed the t() so i created a new patch for that
Comment #6
siddhant.bhosale commentedhi Akshay kashyap, Can you please check the issue in summary, we have a diffrenet issue for replacing t() in assertions.
Comment #7
abhibhatt commentedI have checked the patch #2(3164942-2.patch)in my machine and its working fine for me.
Comment #8
abhibhatt commentedComment #10
longwaveThanks for working on this.
In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Reference: https://www.drupal.org/core/scope#files
In particular, t() calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion. So, closing as a duplicate of the parent issue in #3113904: [META] Replace t() calls inside of classes .
Thanks!