[November 9, 2020] Remove uses of t() in drupalPostForm() calls

Small string concatenation issue.

Thanks for this! Seems like a great start. Very cursory scan looks really good.

Bot found some CS bugs:

9 coding standards messages
✗ 9 more than branch result

/var/lib/drupalci/workspace/jenkins-drupal_patches-47656/source/core/modules/language/tests/src/Functional/LanguageNegotiationUrlTest.php ✗ 1 more
line 5	Unused use statement
/var/lib/drupalci/workspace/jenkins-drupal_patches-47656/source/core/modules/views_ui/tests/src/Functional/HandlerTest.php ✗ 8 more
111	Expected 1 space after comma in argument list; 2 found
111	Expected one space after the comma, 2 found
116	Expected 1 space after comma in argument list; 2 found
116	Expected one space after the comma, 2 found
150	Expected 1 space after comma in argument list; 2 found
150	Expected one space after the comma, 2 found
154	Expected 1 space after comma in argument list; 2 found
154	Expected one space after the comma, 2 found

Thanks,
-Derek

Before:

% grep -r drupalPostForm core | egrep 't\(' | wc
    2249   12282  324258

After:

% grep -r drupalPostForm core | egrep 't\(' | wc
    4      29     806

The 4 are false hits from being too permissive with searching for: "t("

./modules/views_ui/tests/src/Functional/DisplayPathTest.php:    $this->drupalPostForm('admin/structure/views/nojs/display/test_view/page_3/path', ['path' => '<script>alert("hello");</script>'], 'Apply');
./modules/views_ui/tests/src/Functional/DisplayPathTest.php:    $this->drupalPostForm('admin/structure/views/nojs/display/test_view/page_4/path', ['path' => '<script>alert("hello I have placeholders %");</script>'], 'Apply');
./modules/system/tests/src/Functional/Form/ConfirmFormTest.php:    $this->drupalPostForm('form-test/confirm-form', NULL, 'ConfirmFormTestForm::getConfirmText().');
./modules/system/tests/src/Functional/Form/ConfirmFormTest.php:    $this->drupalPostForm('form-test/confirm-form', NULL, 'ConfirmFormTestForm::getConfirmText().', ['query' => ['destination' => 'admin/config']]);

Tests all pass. Bot's happy with code style.

I can't handle line-by-line reviewing a 1mb patch of nearly 20K lines. :/ But a spot check looks totally reasonable everywhere I inspected. I can't imagine @longwave nor @cburschka are trying to sneak in anything here. ;)

re-roll of #7 as it failed to apply

@lal_ I tried to apply the patch, but getting an error (attached screenshot)
also, it will be good if you provide interdiff as well here

Merged 9.1.x.

@naresh_bavaskar, attaching screenshots of your CLI does not really help

Removing credit and screenshot from #14 that was embedded in the summary.

Thanks for working on this monster!

Unfortunately, this already does not apply. Typically, with cleanups this large, we schedule them during the beta or RC phase of a release, to avoid disrupting ongoing work.

The beta window for 9.1 is the week of November 2, so we'd want to schedule it for sometime the week of November 9 or following.

Is someone able to regenerate that patch then? I know it's a ways out.

Wonder if it would make sense to try, in a test issue, to add a temp deprecation trigger like we did in other issues of this kind, to check if any leftover calls remain with an object passed in.

Regardless, this is good cleanup.

#27 +1 yes, in this case it would be probably better to explicitly cast $subject to string in the likely rare case it happens to be an object.

Couple more changes.

We need a deprecation test for the @trigger_error added in #29.

Addressing #32

There's a code standard failure now,

core/tests/Drupal/FunctionalTests/BrowserTestBaseTest.php ✗ 1 more
line 863 Do not pass empty strings to t()

Assuming it turns out green.

Patch no longer applies. We also need a 9.1.x patch without the deprecation or test for it (i.e. just the t() removal).

Fixing the issues.

The 9.2.x patch, 9.1.x one next

9.1.x patch, without deprecation and test

#50 was a random failure.

Back to RTBC since I basically just rerolled.

Committed/pushed to 9.2.x and 9.1.x, thanks!