Problem/Motivation

The test class in core/modules/node/tests/src/Functional/NodeTranslationUITest.php uses a regular database query instead of using an entity query.

Proposed resolution

Replace the regular database query with an entity query.

Remaining tasks

TBD

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

TBD

CommentFileSizeAuthor
#12 interdiff-4-12.txt619 byteshardik_patel_12
#12 3151968-12.patch1.39 KBhardik_patel_12
#7 interdiff-2-4.txt592 byteshardik_patel_12
#4 3151968-4.patch1.37 KBsnehalgaikwad
#2 3151968-2.patch1.07 KBdaffie

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 3151968-2.patch1.07 KB

Patch changes the db query to an entity query.

snehalgaikwad’s picture

snehalgaikwad commented
Assigned: Unassigned » snehalgaikwad
snehalgaikwad’s picture

snehalgaikwad commented
Assigned: snehalgaikwad » Unassigned
StatusFileSize
new 3151968-4.patch1.37 KB

Removed use statement for database, which was not in use.

daffie’s picture

daffie commented

@snehalgaikwad: Can you add an interdiff.txt. It makes reviewing the changes that you made a lot easier.

daffie’s picture

daffie commented

@snehalgaikwad: Can you say that the change from a database query to an entity query is done correctly?

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new interdiff-2-4.txt592 bytes

Interfdiif for patch at #4 and #2. After replacing Database::getConnection()->query with entityQuery 'use Drupal\Core\Database\Database;' becomes unused .

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs review » Reviewed & tested by the community

All the test cases are passed verified on local , so moving to RTBC.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Issue tags: +Bug Smash Initiative
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Issue tags: -Bug Smash Initiative
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/node/tests/src/Functional/NodeTranslationUITest.php
@@ -279,8 +278,13 @@ public function testDisabledBundle() {
-    $this->assertCount(0, $rows);
+    $nids = \Drupal::entityQueryAggregate('node')
+      ->aggregate('nid', 'COUNT')
+      ->condition('type', $this->bundle)
+      ->conditionAggregate('nid', 'COUNT', 2, '>=')
+      ->groupBy('nid')
+      ->execute();

This should have an ->accessCheck(FALSE).

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3151968-12.patch1.39 KB
new interdiff-4-12.txt619 bytes

Adding the requested ->accessCheck(FALSE) to EntityQuery.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Change looks like what @catch requested.
Back to RTBC.

  • catch committed 308db36 on 9.1.x 
    Issue #3151968 by Hardik_Patel_12, daffie, snehalgaikwad: Replace the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 308db36 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.