"Getting the base fields is not supported for entity type" exception in ViewsConfigUpdater

an entity that isn't fieldable, like config entities

What would be the steps to reproduce here? Views doesn't support config entities and all content entities presumably implement ContentEntityInterface which in turn implements FieldableEntityInterface.

Is there an example module somewhere that could cause this?

Closed #3152747: [error] Getting the base fields is not supported for entity type *, I like the fix in that issue a little better. Copying tags over from that issue.

Still have doubts about actively supporting config entities in Views though, but adding a sanity check here seems like a good step. We do need a test for it though.

Here we go with a test and the fix from the other issue. Credited @facine for that. No interdiff because the fix changed.

fixing coding standard issue

Lets see if this clear up the test fail

@Lal_ if you are going to do those types of fixes, do them on patches that are done, not the ones that still have failed tests, just leave a review and check that they are fixed on the next iteration. And if you still want to do this, leave an interdiff and fix all of the CS violations because now it just looks like a credit grab.

Edit: No idea where it cached my version of the -17 patch, but apparently reloading the page doesn't clear my uploads ¯\_(ツ)_/¯, ignore my -17 and take -19

Reuploading the patch that should be committed.

The added fix looks good to me and fixes the problem from the IS.
The added testing also looks good to me.
When I run the test with the full patch the test passes.
When I run the test with only the added test and not the fix the test fails.
For me it is RTBC.

Issues and regressions with the data upgrade path are generally critical, so bumping the priority accordingly. Thanks!

Thanks for triaging this.

#21 has fails like

Testing Drupal\Tests\filter\Functional\FilterFormatAccessTest
EEE                                                                 3 / 3 (100%)

Time: 3.16 seconds, Memory: 4.00 MB

There were 3 errors:

1) Drupal\Tests\filter\Functional\FilterFormatAccessTest::testFormatPermissions
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (9.1.0-dev) requires the 'core' key not be set in core/modules/views/tests/modules/views_config_entity_test/views_config_entity_test.info.yml

The 8.9.x fail has been showing up in HEAD on certain environments, but (weirdly) not others. Going to retest against a couple more environments.

So I can't seem to work around #3153677: Lockfile hash is wrong in 8.9.x since 8.9.1, causing test failures on PHP 7.3+ right now for 8.9.x. However, the failure on 9.1.x means something else is deeply wrong. It has:

	Test Result (3,655 failures / ±0)
#slow.Drupal\Tests\system\Functional\Module\InstallUninstallTest.Drupal\Tests\system\Functional\Module\InstallUninstallTest
#slow.Drupal\Tests\system\Functional\Module\InstallUninstallTest.Unknown
#slow.Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest.Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest
#slow.Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest.Unknown
#slow.Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayBlockFormTest.Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayBlockFormTest
#slow.Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayBlockFormTest.Unknown
#slow.Drupal\KernelTests\Core\Extension\ModuleConfigureRouteTest.Drupal\KernelTests\Core\Extension\ModuleConfigureRouteTest
#slow.Drupal\KernelTests\Core\Extension\ModuleConfigureRouteTest.Unknown
#slow.Drupal\Tests\workspaces\Kernel\WorkspaceIntegrationTest.Drupal\Tests\workspaces\Kernel\WorkspaceIntegrationTest
#slow.Drupal\Tests\workspaces\Kernel\WorkspaceIntegrationTest.Unknown

And clicking on the first of those:

Testing Drupal\Tests\system\Functional\Module\InstallUninstallTest
E                                                                   1 / 1 (100%)

Time: 1.29 seconds, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (9.1.0-dev) requires the 'core' key not be set in core/modules/views/tests/modules/views_config_entity_test/views_config_entity_test.info.yml

/var/www/html/core/lib/Drupal/Core/Extension/InfoParserDynamic.php:88
/var/www/html/core/lib/Drupal/Core/Extension/InfoParser.php:22
/var/www/html/core/includes/module.inc:88
/var/www/html/core/includes/install.inc:1120
/var/www/html/core/includes/install.core.inc:1520
/var/www/html/core/includes/install.core.inc:461
/var/www/html/core/includes/install.core.inc:115
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:286
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:576
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:400
/var/www/html/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php:27
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:691

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

Lets take the core key out of the new test module and see how that goes now

The removal of core: 8.x and the landing of #3153677: Lockfile hash is wrong in 8.9.x since 8.9.1, causing test failures on PHP 7.3+ makes the testbot happy.
Back to RTBC.

I've ran the test without the fix. Getting LogicException: Getting the base fields is not supported for entity type Test config entity type with Views data. so this looks create. Nice to have test coverage.

Committed e685313 and pushed to 9.1.x and 9.0.x. Thanks!
Committed 15e0b54 and pushed to 8.9.x. Thanks!

There was a merge conflict with 8.9.x but it was simple to resolve on commit.

diff --git a/core/modules/views/tests/src/Kernel/ViewsConfigUpdaterTest.php b/core/modules/views/tests/src/Kernel/ViewsConfigUpdaterTest.php
index 5dc26defec..9a94a0de25 100644
--- a/core/modules/views/tests/src/Kernel/ViewsConfigUpdaterTest.php
+++ b/core/modules/views/tests/src/Kernel/ViewsConfigUpdaterTest.php
@@ -23,7 +23,7 @@ class ViewsConfigUpdaterTest extends ViewsKernelTestBase {
   /**
    * {@inheritdoc}
    */
-  public static $modules = ['views_config_entity_test'];
+  protected static $modules = ['views_config_entity_test'];
 
   /**
    * {@inheritdoc}

Fixed on commit.

@sunset_bill: If you think that there are other cases that are not solved with the current patch then please create a new issue and link it to this issue.

After this commit, HEAD is failing on all environments. I don't know if it was a conflict with another patch or what, but I've reverted it for now.

Whoops. And boo public static $modules

RTBC assuming it comes back green.

Committed the hotfixed patch to 8.9.x. Thanks!