Problem/Motivation

For the past several days, HEAD has had the following failure on the PHP 7.3 and 7.4 environments only:
https://www.drupal.org/pift-ci-job/1730795

Drupal\Tests\ComposerIntegrationTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-116.xml:
PHPunit Test failed to complete; Error: PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\ComposerIntegrationTest
F...........S.............................................        58 / 58 (100%)

Time: 876 ms, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\ComposerIntegrationTest::testComposerLockHash
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'00a84fa61ee921f106f7912c3ca0393a2c328e68'
+'38c1ef280518a68c80c796780c4f94a259f50fc0'

I checked by updating the lockfile locally with no other changes to core and it is indeed out of date.

The fact that it only happens on PHP 7.3/7.4 evnvironments leads me to believe it might have something to do with the updated versions of composer.

It's possible that the merge done by the security release needs fixing, since between 8.9.0 and 8.9.1, we committed to that funding info patch, which would also have changed the patch. (Or, maybe that file had an outdated hash to begin with.)

Proposed resolution

Fix the hash and various other lockfile noise.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm’s picture

Title: Lockfile has is wrong in 8.9.x since 9.1.x, causing test failures on PHP 7.3+ » Lockfile hash is wrong in 8.9.x since 9.1.x, causing test failures on PHP 7.3+
xjm’s picture

Title: Lockfile hash is wrong in 8.9.x since 9.1.x, causing test failures on PHP 7.3+ » Lockfile hash is wrong in 8.9.x since 8.9.1, causing test failures on PHP 7.3+
xjm’s picture

Priority: Normal » Critical

Promoting to critical because this can make it difficult to test the forward-compatibillity of 8.9.x backports. It also means the patch default test runs for 8.9.x are much slower than they need to be (since PHP 7.3/7.4 are faster).

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine to me

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6293597 and pushed to 8.9.x. Thanks!

  • alexpott committed 6293597 on 8.9.x
    Issue #3153677 by xjm: Lockfile hash is wrong in 8.9.x since 8.9.1,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.