Fix "Don't" relevant typos in core

There are more instances of "dont", they appear in code and we need to change these to "do_not" etc

@longwave
This may impact some of the test methods which may have been used in other modules/projects/tests.
Also found one instance of url: https://www.drupal.org/docs/8/upgrade/preparing-an-upgrade#dont_create_c....
Shall i go ahead and update?

See https://www.drupal.org/core/d8-bc-policy#tests for the policy regarding tests. Basically we can change individual tests as necessary except for base classes and helpers.

The URL will probably have to be left alone for now.

@longwave. Thanks for the info. Attaching updated patch.

This covers all cases of "dont" or "DONT" in core except one in a d.o URL anchor that we can't change. There are no BC issues because everything is either in test code or CSS comments. We are changing core/tests/Drupal/Tests/Component/Annotation/Doctrine/DocParserTest.php which we inherited from Doctrine but I think a minor spelling fix is acceptable here. Therefore, this is RTBC.

1. +++ b/core/modules/jsonapi/tests/src/Kernel/Query/FilterTest.php
   @@ -67,10 +67,10 @@ public function setUp(): void {
   -      ['colors' => ['orange'], 'shapes' => ['triangle'], 'title' => 'DONT_FIND'],
   +      ['colors' => ['orange'], 'shapes' => ['triangle'], 'title' => 'DO_NOT_FIND'],
          ['colors' => ['yellow'], 'shapes' => ['square'], 'title' => 'FIND'],
   -      ['colors' => ['yellow'], 'shapes' => ['triangle'], 'title' => 'DONT_FIND'],
   -      ['colors' => ['orange'], 'shapes' => ['square'], 'title' => 'DONT_FIND'],
   +      ['colors' => ['yellow'], 'shapes' => ['triangle'], 'title' => 'DO_NOT_FIND'],
   +      ['colors' => ['orange'], 'shapes' => ['square'], 'title' => 'DO_NOT_FIND'],
   

   For these, I verified that the title data is not ever actually used in the test; it's just meant to distinguish which scenarios meet the logic requirements vs. not. So that's all good.
    

2. I also read over MigrateSkipRowTest and SessionTest and their fixtures rather carefully to make sure that the changes to the fixtures didn't alter the test coverage in any way.
    

3. Meanwhile, I updated this URL fragment in the handbook:
   https://www.drupal.org/docs/upgrading-drupal/preparing-a-site-for-upgrad...

   I left an <a> tag with the old name/ID in place also, so that anything else that had the old link would not be broken. Confirmed the link works as expected.

   Updating that URL is also technically backportable since it's one of the placeholder values of the string, rather than part of the first argument of
   t(), so it's not a string break. That said, for good issue scoping, we should still probably separate the test-only changes here from that change.

4. +++ b/core/tests/Drupal/Tests/Component/Annotation/Doctrine/DocParserTest.php
   @@ -1013,7 +1013,7 @@ public function testNotAnAnnotationClassIsIgnoredWithoutWarning()
   -    public function testAnnotationDontAcceptSingleQuotes()
   +    public function testAnnotationDoNotAcceptSingleQuotes()
   

   While @longwave is correct that this would be harmless to change, this file is actually a coding-standards-ignored file, so it should also be a cspell-ignored file IMO. In fact, the entire component should be as well as its test namespace. Can we remove this change from the patch, and incorporate that back into the parent issue?

I grepped the rest of our codebase and... the remaining instances are in fact the French word "dont". La chose exacte dont je parlais! 🇫🇷

NW for that last bullet and also to file the followup for the string URL correction. Thanks!

On this.

Addressing #14.4

Filed: #3143724: Fix "dont" relevant typos in URL string

Ran grep -ri "Dont" * and could find occurance of dont in translations and in /vendor/ckeditor/ckeditor.js which should be OK

modules/migrate_drupal/tests/fixtures/drupal6.php:  'translation' => 'Configurez ici la manière dont les champs et étiquettes de champs de ce type de contenu doivent être affichées, lorsque le contenu est vu en mode résumé ou en pleine page.',
modules/migrate_drupal/tests/fixtures/drupal6.php:  'translation' => "Configurez ici la façon dont les champs de ce type de contenu doivent être affichés lorsqu'il est rendu dans les contextes suivants.",
modules/migrate_drupal/tests/fixtures/drupal6.php:  'translation' => "Configurer la manière dont l'étiquette est affichée.",
modules/migrate_drupal_ui/src/Form/OverviewForm.php:      ':url' => 'https://www.drupal.org/docs/8/upgrade/preparing-an-upgrade#dont_create_content',
tests/Drupal/Tests/Component/Annotation/Doctrine/DocParserTest.php:    public function testAnnotationDontAcceptSingleQuotes()

RTBC for me

CSpell landed today, so we can make sure this spelling error never happens again by removing the entry from Drupal's dictionrary, so let's update the patch to include that. I think the French content should already be ignored, but if not, we should ignore the translations where it appears.

We should also add all of core/tests/Drupal/Tests/Component/Annotation/Doctrine to the ignored files. Thanks!

Removed 'dont' from core/misc/cspell/dictionary.txt and added core/tests/Drupal/Tests/Component/Annotation/Doctrine to the ignored files.

+++ b/core/.cspell.json
@@ -21,7 +21,8 @@
+      "core/tests/Drupal/Tests/Component/Annotation/Doctrine"

These paths are relative to the "core" directory so we don't need "core/" at the start of the path.

Here I have addressed comment #24.

We also need to add /** to ignore all the files below that directory, and I took the liberty of keeping the (mostly) alphabetical order of the exclusions as well.

So we should also regenerate the dictionary, as there are a number of misspelled words that only appear in the Doctrine component. The attached patch removes those words from the dictionary as well as "dont".

Working on this.

Rolling done, please review, thanks.

Needs a reroll.

rerolled

oops the patch

Thanks for rerolling, back to RTBC.

Committed 5412462 and pushed to 9.1.x. Thanks!
Committed and pushed 3b668ff177 to 9.0.x and 3a730ce872 to 8.9.x. Thanks!

Backported to 8.9.x without the cspell changes as this is test only.