Problem/Motivation

Following packages have updates:

Package Current Wanted Latest URL
@babel/core 7.8.3 7.9.0 7.9.0 https://babeljs.io/
@babel/preset-env 7.8.3 7.9.0 7.9.0 https://babeljs.io/
@babel/register 7.8.3 7.9.0 7.9.0 https://github.com/babel/babel/tree/master/packages/babel-register
eslint-config-airbnb 18.0.1 18.1.0 18.1.0 https://github.com/airbnb/javascript
eslint-plugin-react 7.18.0 7.19.0 7.19.0 https://github.com/yannickcr/eslint-plugin-react
postcss-custom-properties 9.0.2 9.1.1 9.1.1 https://github.com/postcss/postcss-custom-properties#readme
Patch
Package Current Wanted Latest URL
autoprefixer 9.7.4 9.7.5 9.7.5 https://github.com/postcss/autoprefixer#readme
eslint-config-prettier 6.10.0 6.10.1 6.10.1 https://github.com/prettier/eslint-config-prettier#readme
eslint-plugin-import 2.20.0 2.20.2 2.20.2 https://github.com/benmosher/eslint-plugin-import
postcss 7.0.26 7.0.27 7.0.27 https://postcss.org/
postcss-calc 7.0.1 7.0.2 7.0.2 https://github.com/postcss/postcss-calc#readme
terser 4.6.3 4.6.9 4.6.9 https://terser.org

Proposed resolution

Update yarn dependencies that can be updated automatically. This is being split into child issues:

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

lauriii created an issue. See original summary.

lauriii’s picture

Status: Active » Needs review
StatusFileSize
new110.86 KB

I used following commands for generating the patch:

  • yarn upgrade
  • yarn run build:js
  • yarn run build:css
  • yarn lint:css
  • yarn lint:core-js-passing

Status: Needs review » Needs work

The last submitted patch, 2: 3123751-2.patch, failed testing. View results

lauriii’s picture

Status: Needs work » Needs review
StatusFileSize
new114.94 KB

Updated packages again.

bnjmnm’s picture

Status: Needs review » Needs work

Ran yarn outdated and autoprefixer has a 9.7.6 update available as of 16 hours ago 🙂

abhisekmazumdar’s picture

Updated Patch.

abhisekmazumdar’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: update_yarn_dependencies-3123751-6.patch, failed testing. View results

abhisekmazumdar’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

I applied #6 and then reran the commands in #2 and there are no differences, therefore we are on the latest versions for everything and this is good to go.

catch’s picture

+++ b/core/themes/claro/js/tabledrag.js
@@ -5,7 +5,7 @@
 
-function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
+function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
 

Do we really want this @babel/helplers stuff in core js? It is very possible I've missed something and we do, but first time I've seen it.

lauriii’s picture

It seems like they've added the directive to the beginning of the function body in https://github.com/babel/babel/pull/11049 to make it easier for other Babel plugins to identify that this code doesn't have to be processed since it's generated by Babel itself. I'm not sure if there's a strong urge for us to get out of our way to remove it even though it isn't necessarily something we need in our production code.

xjm’s picture

Status: Reviewed & tested by the community » Postponed

I also had the same reaction as #11.

We should probably do #3107926: Update stylelint to ^13.0.0 first and then regenerate some updates -- postponing on that issue.

nod_’s picture

Status: Postponed » Needs work

With nodejs 12.17.0 our js compiling script is broken, upgrading all babel dependencies fixes thing, but like said in #11 there is some extra stuff in the generated JS.
#3143289: Upgrade babel dependencies (yarn run build:js broken)

dww’s picture

Priority: Normal » Major

Should this become a META and we set #3118741: [Security] Update yarn dependencies to fix security issues as another child?

dww’s picture

Title: Update yarn dependencies » [META] Update yarn dependencies
Category: Task » Plan
Issue summary: View changes
Status: Needs work » Active

Removing duplicate devDependencies column to try to get the summary to fit better instead of crashing into sidebar so much. ;)

Turning this into a meta since there are multiple children to help scope.

dww’s picture

Issue summary: View changes

Removing empty CHANGELOG column.

xjm’s picture

So @dww I think on 9.0.x we should be using the full update here. It's 8.9.x and especially 8.8.x that need more careful updates to reduce risk of regressions.

Version: 9.0.x-dev » 9.1.x-dev

Drupal 9.0.10 was released on December 3, 2020 and is the final full bugfix release for the Drupal 9.0.x series. Drupal 9.0.x will not receive any further development aside from security fixes. Sites should update to Drupal 9.1.0 to continue receiving regular bugfixes.

Drupal-9-only bug reports should be targeted for the 9.1.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.2.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lauriii’s picture

Status: Active » Closed (outdated)