Problem/Motivation
Following packages have updates:
| Package | Current | Wanted | Latest | URL |
|---|---|---|---|---|
| @babel/core | 7.8.3 | 7.9.0 | 7.9.0 | https://babeljs.io/ |
| @babel/preset-env | 7.8.3 | 7.9.0 | 7.9.0 | https://babeljs.io/ |
| @babel/register | 7.8.3 | 7.9.0 | 7.9.0 | https://github.com/babel/babel/tree/master/packages/babel-register |
| eslint-config-airbnb | 18.0.1 | 18.1.0 | 18.1.0 | https://github.com/airbnb/javascript |
| eslint-plugin-react | 7.18.0 | 7.19.0 | 7.19.0 | https://github.com/yannickcr/eslint-plugin-react |
| postcss-custom-properties | 9.0.2 | 9.1.1 | 9.1.1 | https://github.com/postcss/postcss-custom-properties#readme |
| Package | Current | Wanted | Latest | URL |
|---|---|---|---|---|
| autoprefixer | 9.7.4 | 9.7.5 | 9.7.5 | https://github.com/postcss/autoprefixer#readme |
| eslint-config-prettier | 6.10.0 | 6.10.1 | 6.10.1 | https://github.com/prettier/eslint-config-prettier#readme |
| eslint-plugin-import | 2.20.0 | 2.20.2 | 2.20.2 | https://github.com/benmosher/eslint-plugin-import |
| postcss | 7.0.26 | 7.0.27 | 7.0.27 | https://postcss.org/ |
| postcss-calc | 7.0.1 | 7.0.2 | 7.0.2 | https://github.com/postcss/postcss-calc#readme |
| terser | 4.6.3 | 4.6.9 | 4.6.9 | https://terser.org |
Proposed resolution
Update yarn dependencies that can be updated automatically. This is being split into child issues:
- @babel/* #3143289: Upgrade babel dependencies (yarn run build:js broken)
- nightwatch #3118741: [Security] Update yarn dependencies to fix security issues
- eslint #3118741: [Security] Update yarn dependencies to fix security issues
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff.3123751.4-6.txt | 13.67 KB | abhisekmazumdar |
| #6 | update_yarn_dependencies-3123751-6.patch | 116.3 KB | abhisekmazumdar |
| #4 | 3123751-4.patch | 114.94 KB | lauriii |
| #2 | 3123751-2.patch | 110.86 KB | lauriii |
Comments
Comment #2
lauriiiI used following commands for generating the patch:
yarn upgradeyarn run build:jsyarn run build:cssyarn lint:cssyarn lint:core-js-passingComment #4
lauriiiUpdated packages again.
Comment #5
bnjmnmRan
yarn outdatedand autoprefixer has a 9.7.6 update available as of 16 hours ago 🙂Comment #6
abhisekmazumdarUpdated Patch.
Comment #7
abhisekmazumdarComment #9
abhisekmazumdarComment #10
longwaveI applied #6 and then reran the commands in #2 and there are no differences, therefore we are on the latest versions for everything and this is good to go.
Comment #11
catchDo we really want this @babel/helplers stuff in core js? It is very possible I've missed something and we do, but first time I've seen it.
Comment #12
lauriiiIt seems like they've added the directive to the beginning of the function body in https://github.com/babel/babel/pull/11049 to make it easier for other Babel plugins to identify that this code doesn't have to be processed since it's generated by Babel itself. I'm not sure if there's a strong urge for us to get out of our way to remove it even though it isn't necessarily something we need in our production code.
Comment #13
xjmI also had the same reaction as #11.
We should probably do #3107926: Update stylelint to ^13.0.0 first and then regenerate some updates -- postponing on that issue.
Comment #14
nod_With nodejs 12.17.0 our js compiling script is broken, upgrading all babel dependencies fixes thing, but like said in #11 there is some extra stuff in the generated JS.
#3143289: Upgrade babel dependencies (yarn run build:js broken)
Comment #15
dwwShould this become a META and we set #3118741: [Security] Update yarn dependencies to fix security issues as another child?
Comment #16
dwwRemoving duplicate
devDependenciescolumn to try to get the summary to fit better instead of crashing into sidebar so much. ;)Turning this into a meta since there are multiple children to help scope.
Comment #17
dwwRemoving empty CHANGELOG column.
Comment #18
xjmSo @dww I think on 9.0.x we should be using the full update here. It's 8.9.x and especially 8.8.x that need more careful updates to reduce risk of regressions.
Comment #19
alexpottAdded two more children... #3145177: Update JS dev dependencies for latest major versions and #3145197: Update eslint to v7 and prettier to v2 when airbnb standard supports it
Comment #21
lauriii