Upgrade babel dependencies (yarn run build:js broken)

Seems to be considered a bug in Node itself but can't really tell whether this will be fixed or it is just intended behaviour now: https://github.com/nodejs/node/issues/32107

No longer applies after #3107926: Update stylelint to ^13.0.0 landed.

This seems to be happening in a couple (but not all) of our test environments now (PHP dev version environments for some reason?), so bumping to critical.
https://dispatcher.drupalci.org/job/drupal8_core_regression_tests/21714/...
https://dispatcher.drupalci.org/job/drupal8_core_regression_tests/21713/...
https://dispatcher.drupalci.org/job/drupal8_core_regression_tests/21717/...

22:02:49    Error: An error occurred while trying to start the Nightwatch Runner: No "exports" main resolved in /var/www/html/core/node_modules/@babel/helper-compilation-targets/package.json

patch -p1 < core-js-babel-3143289-1.patch gave: 4 out of 48 hunks FAILED. :/

This patch keeps the js changes from #1, resets yarn.lock to commit b086cafd9, then runs:

yarn upgrade '@babel/core'
yarn upgrade '@babel/preset-env'

Output attached. Interdiff doesn't work, rawdiff is huge. Hope this is the kind of re-roll we need.

After running this, yarn run build:js doesn't error.

Looking at the parent issue and the title here, maybe we should also yarn upgrade @babel/register?

Queued the above against the environments that are failing in HEAD.

Just a test patch to expose the fails in HEAD (I hope),

Those 'build successful' results are exposing the error as expected:

./node_modules/.bin/nightwatch --config ./tests/Drupal/Nightwatch/nightwatch.conf.js
14:47:06    Error: An error occurred while trying to start the Nightwatch Runner: No "exports" main resolved in /var/www/html/core/node_modules/@babel/helper-compilation-targets/package.json

Queued a new more tests for #9, to see if consistently passes and #11, to see if it consistently fails.

I test building patch as per @dww instruction in #8 and #9

1. git checkout 9.1.x
2. git checkout b086cafd9 -- core/yarn.lock(not sure we are doing this, just to get the previous patch to apply?)
3. rm -rf node_modules
4. Do changes to core/package.json from #1(not the actual js file changes)
5. yarn install

6. yarn upgrade '@babel/core'
   yarn upgrade '@babel/preset-env'
   yarn upgrade @babel/register
   

7. yarn build:js

The result of this matches the patch in #9
I don't understand Step 2). If this was just temp fix I can re-roll without this.

Rebuilding without reseting yarn.lock

re my question in #14 and @dww's comment #8

resets yarn.lock to commit b086cafd9

I rebuilt the patch according to #14 except #14.2

The changes still came out the same as #9

The patch looks good to me.

+++ b/core/package.json
@@ -65,6 +65,9 @@
+        "exclude": [
+          "transform-es2015-typeof-symbol"
+        ],

@@ -78,6 +81,9 @@
+        "exclude": [
+          "transform-es2015-typeof-symbol"
+        ],

The only thing I don't about is this as to whether it would cause a problem but since @nod_ suggested this as Javascript maintainer he should know if removing typeof would not work everywhere, see #2

+++ b/core/yarn.lock
@@ -650,163 +728,187 @@
-"@babel/preset-env@^7.0.0":
-  version "7.8.3"
...
+"@babel/preset-env@^7.0.0":
+  version "7.10.2"

Wouldn't doing just this be enough since this has been fixed in the preset-env library? At least this fixed it for me.

This one is less scary dependency-wise; just a minor update for Babel and a handful of patch- and minor-level updates. No added dependencies outside the Babel scope.
https://docs.google.com/spreadsheets/d/1wm6tObzNMZwcDnA3mqgXDlGyV94i-m7s...

Sorry for any confusion from #8. I was trying to show I was using the (then) head of 9.1.x version of yarn.lock before I started the yarn upgrade commands.

+1 that #18 is RTBC: solves the build errors locally, with fewer changes, and is RTBC.

Thanks!
-Derek

This was resolved by #3118741: [Security] Update yarn dependencies to fix security issues. Everyone from this issue have been given credit on that issue.