Problem/Motivation

When adding new field in view, the notification message misses left-padding

Steps to reproduce:

  1. Set Claro as default admin theme
  2. Add a new view. Choose display Fields
  3. Add a new field - a new notice message added in the popup "Selected: field name"

Left padding is missing from add field in views
This also happens when hit "Add" buttons in any categories of the Views form, and ticking any checkbox on the pop-up.
Tested on both Drupal 8.8.2 and 8.9, Chrome, Firefox and IE on Windows.

Proposed resolution

Add left padding to the left of the notice message
Added left padding

Remaining tasks

Needs review, and align with the related issues #3066006

User interface changes

Yes. Minor interface changes - Add padding to notice as screenshot below

API changes

NA

CommentFileSizeAuthor
#8 selected_8415.png500.27 KBKondratievaS
#5 Claro_padding_text.png549.65 KBabhisekmazumdar
#4 3115481-4.patch1.13 KBsnehalgaikwad
after-padding-added.JPG46.36 KBkualee
padding_missing_view.JPG133.51 KBkualee

Comments

kualee created an issue. See original summary.

kualee’s picture

kualee
she/her
Primary language English
commented

The simplest way to fix this issue is to add padding-left in the line below 

.views-ui-dialog .views-add-form-selected.container-inline {
    padding: 0;
    <strong>padding-left: 1em;</strong>
}

Though I won't create a patch as this potentially is only Claro theme related, adding the code above would affect other themes as well

snehalgaikwad’s picture

snehalgaikwad commented
Assigned: Unassigned » snehalgaikwad
snehalgaikwad’s picture

snehalgaikwad commented
Assigned: snehalgaikwad » Unassigned
Status: Active » Needs review
StatusFileSize
new 3115481-4.patch1.13 KB
abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Claro_padding_text.png549.65 KB

I have reviewed the changes, it looks good.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Is this bug specific to Claro? If it is, we should probably handle it in #3023311: Modal dialog style update. If it isn't this needs to be fixed in Seven as well.

kualee’s picture

kualee
she/her
Primary language English
commented

Yes I do believe this is Claro-specific, will do more testing to be certain. Good idea re #3023311

KondratievaS’s picture

KondratievaS commented
StatusFileSize
new selected_8415.png500.27 KB

Tested in Claro and Seven themes and result is OK in both themes

OK

KondratievaS’s picture

KondratievaS commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3115481-4.patch, failed testing. View results

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Closed (duplicate)

This issue is a duplicate of https://www.drupal.org/project/drupal/issues/3023311