\Drupal calls should be avoided in classes, use dependency injection instead in the Workflows module

Looks good. Patch applies and code does what it is intended for.

@Hardik_Patel_12 thank you for your contribution.

At a minimum this needs to address WorkflowTransitionAddForm too but the rest of the Workflows module should be checked as well. Also the scope of these "\Drupal calls should be avoided in classes, use dependency injection instead..." issues should be agreed in #2729597: [meta] Replace \Drupal with injected services where appropriate in core as there appears to be a lot of prior art.

Also you need to do the deprecation dance in the constructor and add a change record. When we add arguments to a constructor like this we make them optional and do a deprecation if called without. See for example the code in \Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection::__construct() on Drupal 8.9.x

Also new deprecations (for Drupal 10) at the moment will done once 9.1.x opens as the higher priority work is to remove deprecations from Drupal 9.

please review the new patch.

Since EntityForm class already has $entityTypeManager variable defined , the class extending it need not redefine it using ContainerInterface implementation.

+++ b/core/modules/workflows/src/Form/WorkflowStateAddForm.php
@@ -24,6 +24,7 @@ class WorkflowStateAddForm extends EntityForm {
+

There is some extra whitespace added here.

please review the new patch .

Thank you for filing this and for your contributions so far.

I am closing this as a duplicate of #2729597: [meta] Replace \Drupal with injected services where appropriate in core. You can use the work in the patches from this and similar issues as starting points for new issues scoped by concept.