Problem/Motivation

tracker_cron() entity queries don't have ->accessCheck(FALSE) - this means that if you're using node grants, you may not get all of the nodes indexed.

Proposed resolution

Remaining tasks

Test coverage.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3105711.patch892 bytescatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new 3105711.patch892 bytes
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

It is unfortunate that it will be difficult to test. Nodes don't have access limitations normally affixed to them. 'entity_test' does, but then we're not using node any more and tracker won't query it. But perhaps for inspiration, look at https://git.drupalcode.org/project/migrate_plus/blob/8.x-5.x/tests/src/K... for a similar type case that we wanted to test.

Tagging for tests and bump to NW for those tests.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.0.x-dev » 8.8.x-dev

I assume this affects D8 too? Thanks!

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Closed (duplicate)

This was fixed by #2785449: It's too easy to write entity queries with access checks that must not have them.