Expected type hint "WorkflowInterface"; found "WorkflowTypeInterface" for $workflow in core/modules/workflows/src/State.php file
Expected type hint "WorkflowInterface"; found "WorkflowTypeInterface" for $workflow in core/modules/workflows/src/Transition.php file

CommentFileSizeAuthor
#5 expected_type_hint-3105288-5.patch1.57 KBsnehalgaikwad
#4 interdiff-3105288-2-4.txt2.46 KBhardik_patel_12
#4 expected_type_hint-3105288-4.patch1.88 KBhardik_patel_12
#2 expected_type_hint-3105288-2.patch1.6 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new expected_type_hint-3105288-2.patch1.6 KB

kindly review a patch

Status: Needs review » Needs work

The last submitted patch, 2: expected_type_hint-3105288-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new expected_type_hint-3105288-4.patch1.88 KB
new interdiff-3105288-2-4.txt2.46 KB

Kindly follow a new patch.

snehalgaikwad’s picture

snehalgaikwad commented
StatusFileSize
new expected_type_hint-3105288-5.patch1.57 KB

Updated patch after removing the use statement. There was no need of use statement for interface.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs review » Reviewed & tested by the community

#5 above patch works fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.9.x-dev » 8.8.x-dev
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Committed and pushed 19da60cf0f to 9.0.x and 8ffdade27c to 8.9.x and 9a161f421f to 8.8.x. Thanks!

Backported to 8.8.x since this is incorrect documentation.

  • alexpott committed 19da60c on 9.0.x 
    Issue #3105288 by Hardik_Patel_12, snehalgaikwad: Expected type hint "...

  • alexpott committed 8ffdade on 8.9.x 
    Issue #3105288 by Hardik_Patel_12, snehalgaikwad: Expected type hint "...

  • alexpott committed 9a161f4 on 8.8.x 
    Issue #3105288 by Hardik_Patel_12, snehalgaikwad: Expected type hint "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.