Unordered lists override numbered lists

The RTL overrides aren't needed. The changes in style.css is good enough to let it cascade through.

Never mind that.. My bad. It is needed but the patch isn't diffed from root.

Not sure I understand this patch. What do you mean with "an ordered list in an unordered list". Can you provide a screenshot to help me understand? That would be really useful. Thanks!

If I understand this correctly, we have CSS selectors for ul li that change the list-style-type to bullet. But in the following situation:

<ul>
 <li>A. Item</li>
 <ol>
  <li>Sub-item 1</li>
  <li>Sub-item 2</li>
 </ol>
 <li>B. Item</li>
</ul>

... the <li> tags inside the <ol> tag also match ul li because there are also children of the enclosing <ul> tag.

If I understand the patch correctly, it adds a selector to ol li to reverse that behavior. But it means that unordered lists inside ordered lists will now get overriden!

We will need a CSS guru here, but I'm not sure this issue can be solved cleanly without CSS 2.1 "child selector" (ol > li and ul > li), which are not supported by IE 6 (source).

This means this needs work.

Your right Damien. This stems from the fact that Garland uses a background image instead of bullet images.

If we can get Stefan to comment on why this is, maybe we can get it back to using the image in the bullets and not the background without worries.

To be a little more clear on the fix, if the bullet image is applied to the enclosing "ul" tag, it will cascade to the child "li". This applies in IE too and would bypass the need for the ">" modifier. Then it would be a matter of setting "list-style-image" to "none" for the "ol" tag and this would be fixed.

There's a lot of spacing in those lists and any changes there need to be sorted out without breaking anything else.

@Dries, here's an example:

• item a
• item b
• item c
  1. sub-item c
  2. sub-item c
  3. sub-item c

List item c contains an ordered list. Due to the way Garland uses images and its selectors for unordered lists, the ordered list will omit the numbers on the left.

The list items bullets are no longer using the background image property. It's using "list-style-image" as I mentioned before. There were a few unneeded styles due to the change so they've been removed.

There was a missing book module style for RTL flow. I tested this in both directions and it seems to be working just fine.

Forgot about IE6..

I committed this to CVS HEAD but it should probably go into Drupal 6 as well. Updating version.

The alignment of lists is now a little messed-up (Firefox 3 here):

Nice catch. Cleaned up and ready to go!

Except for IE of course. Thought I could clean some of the selectors up but it was needed for IE. I put them back.

One more try. "ul" and "ol" without any classes applied didn't indent properly.

whoops

Did I say one more try.? err.

Looks fine visually, could we get a screenshot to see the changes?

In non-IE browsers, this patch caused Garland to use black solid bullets in the login form where it used to be white circle bullets. This affects D7 head.

I believe I'm fixing the fallout caused by the patch in #394670: Bullet on UL lists showing up incorrectly.

Can I have the patched style.css and style-rtl.css that fix the Garland ordered and unordered list for Drupal 6.12?

Edit I selected 6.12 but this forum gives me 7.x dev. ???

Tested in 7.22, and the CSS is fine. Found a problem with the input filter when trying to use the HTML in #7 though. Started a new issue #2014327: "Correct faulty and chopped off HTML" does not handle nested lists correctly