#2492171: Provide options to sanitize filenames (transliterate, lowercase, replace whitespace, etc) is blocked on #3032390: Add an event to sanitize filenames during upload which is itself languishing.
People are re-rolling older versions of #2492171 and confusing things in the parent issue.
Post "composer-friendly" re-rolls here, so as not to further confuse the parent issue.
-
-
-
-
-
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | interdiff_12-14.txt | 7.49 KB | hkirsman |
| #14 | 3094052-14.patch | 8.74 KB | hkirsman |
| #12 | 3094052-12.patch | 9.67 KB | shaunlaws |
| #9 | 3094052-9.patch | 9.61 KB | nlisgo |
| #7 | reroll_diff_2-7.txt | 7.52 KB | gbeezus |
Comments
Comment #2
nlisgo commentedComment #3
nlisgo commented@dww apologies for posting the patch in the parent issue. I was rushing trying to get my site onto Drupal 8.8 and trying to be a good citizen and post the patch. This is a good compromise. Thanks for setting up this child issue.
Comment #4
dwwNo worries. Apologies for slightly losing my temper. The parent issue has been quite a frustrating journey. Glad you agree this child issue is a good compromise.
Cheers,
-Derek
Comment #6
pavelculacov commentedMake this patch for D9?
Comment #7
gbeezus commentedAttempted reroll. There was a merge conflict in the file.module right around line 1034.
Comment #9
nlisgo commentedThanks @gbeezus for the re-roll. The number of failed tests made me concerned so I decided to take another pass at it. Hopefully this will work.
Comment #10
nlisgo commented@Regnoy I will work on a patch for D9 tomorrow if I get a chance.
Comment #11
pavelculacov commented@nlisgo some changes?
Comment #12
shaunlaws commentedI had a crack at rerolling https://www.drupal.org/files/issues/2020-11-19/3094052-9.patch for Drupal 9. The attached patch applied successfully against Drupal 9.1.8 but I couldn't get the tests to pass locally. With the 'Enable filename transliteration' option checked on the file system admin page I got the following transliterations:
'TEXT-Å“.txt' uploaded as 'text-afaeuacaa.txt' (tests expected 'text-a.aeuoe.txt'
'S Pace--🙈.txt' -> 's-pace-afadega.aacaeuzacaaeu-.txt' (tests expected 's-pace-adegaace.txt')
I ran out of time to work more on it, but hopefully the patch is a useful start for someone to figure out why the tests fail.
Comment #13
ganesh_kumar commentedHi ShaunLaws
This patch getting failed during upgrade of drupal 8 to latest release
drupal 9 #3094052-12.patch. and getting the below error refer failed patch one while during update the composer.
Could you please update the patch of supporting the D9 as well to sort out this issue.
Failed Patch
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2021-05-12/3094052-12.patch
Comment #14
hkirsman commentedRe-rolling patch against 9.2.10
Comment #17
andypostComment #18
smustgrave commentedAppears to be blocked on #2492171: Provide options to sanitize filenames (transliterate, lowercase, replace whitespace, etc)
Comment #19
dwwThe main feature is now in, so this issue doesn't need to remain open. 🎉