Problem/Motivation

Class docs for BrowserTestBase helpfully say:

 * Tests extending BrowserTestBase must exist in the
 * Drupal\Tests\yourmodule\Functional namespace and live in the
 * modules/yourmodule/tests/src/Functional directory.

The base classes for the other 3 types of test should say something similar: Drupal\Tests\UnitTestCase, Drupal\KernelTests\KernelTestBase, Drupal\FunctionalJavascriptTests\WebDriverTestBase.

Steps to reproduce

Proposed resolution

The base classes for the other 3 types of test should say something similar: Drupal\Tests\UnitTestCase, Drupal\KernelTests\KernelTestBase, Drupal\FunctionalJavascriptTests\WebDriverTestBase.

Remaining tasks

Add followup to provide details of where core tests, not in core modules, should live.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#15 3089907-14.patch1.98 KBsahil.goyal
#14 reroll_diff_3-13.txt2.17 KBsahil.goyal
#14 3089907-13.patch1.98 KBsahil.goyal
#3 standardize_docs_on_how_to_use_the_4_types_of_test_base-3089907-3.patch1.97 KBtbsiqueira

Issue fork drupal-3089907

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

tbsiqueira’s picture

tbsiqueira
He/him
commented

I'm at #Amterdam2019 and I am working on this now. #DrupalCon2019

tbsiqueira’s picture

tbsiqueira
He/him
commented
Status: Active » Needs review
StatusFileSize
new standardize_docs_on_how_to_use_the_4_types_of_test_base-3089907-3.patch1.97 KB

Please find patch attached

tbsiqueira’s picture

tbsiqueira
He/him
commented
Issue tags: +Amsterdam2019
sutharsan’s picture

sutharsan commented
Status: Needs review » Reviewed & tested by the community

@tbsiqueira, Thanks for the work. The code looks good, code style Ok, text content Ok. Nicely consistent.

tbsiqueira’s picture

tbsiqueira
He/him
commented

@Sutharsan, than you for the review! Happy to help.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

This comments added here are true for contrib and custom modules & themes but they are not true for core. The documentation we're adding here needs to reflect that it is for contrib and custom modules & themes.

joachim’s picture

joachim commented

Presumably they're true for core modules and themes, but not for tests for core lib?

We should explain where they need to go for core lib tests too -- core should be documenting itself!

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sahil.goyal’s picture

sahil.goyal commented
StatusFileSize
new 3089907-13.patch1.98 KB
new reroll_diff_3-13.txt2.17 KB

The patch provided at #3 looks great but as version changed the patch is no longer compatible with the 9.4.x so i reroll the patch to make it applied for newer version as well. otherwise added comments are look good.

sahil.goyal’s picture

sahil.goyal commented
StatusFileSize
new 3089907-14.patch1.98 KB

Fixing the CCF at above.

sahil.goyal’s picture

sahil.goyal commented
Status: Needs work » Needs review
gaurav-mathur’s picture

gaurav-mathur commented
Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

gaurav-mathur commented
Assigned: gaurav-mathur » Unassigned

Verified and tested patch#15 on Drupal 9.5.x-dev and do not see any error or warnings.
Patch applied successfully.
Thank You.

joachim’s picture

joachim commented
Version: 9.5.x-dev » 10.1.x-dev

We need to move this to 10.1, but it should hopefully still apply.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

From what I can tell

We should explain where they need to go for core lib tests too -- core should be documenting itself!

Still needs to be addressed.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone made their first commit to this issue’s fork.

quietone opened merge request !8855

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +Needs followup

We should explain where they need to go for core lib tests too -- core should be documenting itself!

Let's move that to a follow up issue so we can make this improvement.

I have convert to an MR and made a slight change to indicate this is for modules.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs followup +Needs Review Queue Initiative

Opened #3462973: Provide details of where core tests, not in core modules, should live.

nod_ closed merge request !8855

  • nod_ committed c70620dc on 11.x 
    Issue #3089907 by sahil.goyal, quietone, tbsiqueira, joachim, smustgrave...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed c70620d and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.