Comments

damien tournoud’s picture

StatusFileSize
new1.1 KB

I think it looks more Drupal-ish this way.

damien tournoud’s picture

Status: Needs review » Reviewed & tested by the community

Small cleanup, ready to get in.

catch’s picture

Looks fine to me, test still passes.

webchick’s picture

Status: Reviewed & tested by the community » Postponed

So I understand that this patch is cleaning up some messages from the "old" way we used to do things to something a bit more modern. However, this feels to me like a classic example of "lipstick on a pig."

We're avoiding a huge elephant in the room about the fact that our tests to a large extent have very little consistency and are all over the map in terms of when they do and do not do assertions, what those assertion messages are called, and so on. I think we need to flesh out and agree upon One Test Template To Rule Them All, and then apply that in a serious of core-wide test suite clean-up patches, rather than several of these little tiny ones that are taking a stab but not addressing the underlying problem.

Therefore, marking postponed. I'll ping back here in a moment with a URL to the testing-qa group where we can hash this out once and for all.

webchick’s picture

jody lynn’s picture

Component: tests » ajax system
Status: Postponed » Closed (cannot reproduce)

This issue is no longer relevant as the lines being cleaned up no longer exist as such.

jody lynn’s picture

Component: ajax system » contact.module