Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
In #3075490: Move simpletest module to contrib we're trying to remove the simpletest module from core.
If we study the test results in comment #28, we can see that there are two types of tests which require the simpletest module: Those which reference the module directly, and those which rely on DB dumps and other fixtures which refer to the simpletest module. #3075490-28: Move simpletest module to contrib
This issue is scoped with changing tests which don't require changes to fixtures. The current list is:
core/modules/content_translation/tests/src/Kernel/ContentTranslationFieldSyncRevisionTest.phpcore/modules/image/tests/src/Kernel/ImageThemeFunctionTest.phpcore/modules/migrate/tests/src/Kernel/Plugin/MigrationPluginListTest.phpcore/modules/migrate_drupal/tests/src/Kernel/StateFileExists.phpcore/modules/system/tests/src/Functional/Form/ModulesListFormWebTest.phpcore/tests/Drupal/KernelTests/Core/Asset/AttachedAssetsTest.phpcore/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php
Proposed resolution
Change the tests so they don't need simpletest.
Remaining tasks
Commit patch #4.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff.txt | 2.51 KB | mile23 |
| #4 | 3082414_4.patch | 2.49 KB | mile23 |
| #2 | 3082414_2.patch | 5 KB | mile23 |
Comments
Comment #2
mile23An early patch.
Note that a couple of these mark the test incomplete, which doesn't actually fail drupalci.
Comment #4
mile23Given that we're likely going to keep a stub simpletest module in core #3057420-46: [meta] How to deprecate Simpletest with minimal disruption, we can loosen our expectations on some of the tests here. We'll encounter these tests as we remove features from the simpletest module in D9.
This patch removes references to simpletest module from tests that truly don't need it. This is based on analysis of test fails in #3075490-28: Move simpletest module to contrib, where we remove the simpletest module completely.
Comment #5
dww#4 looks good to me. It simply removes 'simpletest' from the $modules (to-install) list on 4 tests. Bot came back all green for this, so clearly, those are completely unnecessary references. Let's remove them to make things easier for #3075490: Move simpletest module to contrib (and generally, to remove overhead and bloat that we don't need).
Thanks!
-Derek
Comment #6
larowlanCommitted 1f1dfce and pushed to 8.8.x. Thanks!