Problem/Motivation

Some of the test topics, test modules, and tests in Help Topics are relying on production help topics, or linking to production help topics. This could cause problems if one of the production help topics changes, gets deleted, etc.

Proposed resolution

Make it so the tests and test modules for Help Topics are completely decoupled from production topics.

Remaining tasks

Make a patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#2 3076348.patch2.39 KBjhodgdon

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3076348.patch2.39 KB

Here's a patch that removes all references to production topics in the tests and test module/theme. Tests pass locally.

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented

Looks ok to me! Tests passed locally for me as well. Thanks @jhodgdon!

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Reviewed & tested by the community
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed 16af98f and pushed to 8.8.x. Thanks!

  • larowlan committed 16af98f on 8.8.x 
    Issue #3076348 by jhodgdon: Refactor help topic tests so they do not use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.