Fix spelling of "email"

length of the string is 100 after the change

-  'options' => 'a:1:{s:10:"attributes";a:1:{s:5:"title";s:101:"Configure default behavior of users, including registration requirements, e-mails, and user pictures.";}}',
+  'options' => 'a:1:{s:10:"attributes";a:1:{s:5:"title";s:101:"Configure default behavior of users, including registration requirements, emails, and user pictures.";}}',

Verified no more 'e-mail' exists in Core.

This looks RTBC to me,

Thank you for your work on cleaning up Drupal core's code style!

In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core, stage 1. A good place to start is the child issues of #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard.

What we need here is a new rule added to the coder project to check our code for adding e-mail as we're obviously not going to remember this decision in the future.

For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.

Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.

+++ b/core/modules/migrate_drupal/tests/fixtures/drupal6.php
@@ -191,7 +191,7 @@
-  'description' => 'Send e-mail',
+  'description' => 'Send email',

@@ -15324,14 +15324,14 @@
-  'source' => "The <em>From</em> address in automated e-mails sent during registration and new password requests, and other notifications. (Use an address ending in your site's domain to help prevent this e-mail being flagged as spam.)",
+  'source' => "The <em>From</em> address in automated emails sent during registration and new password requests, and other notifications. (Use an address ending in your site's domain to help prevent this email being flagged as spam.)",

This is life as it was in Drupal 6 and we should not be changing it here - or anywhere else in this file. Or in the Drupal 7 file.

Adding a patch as it was failing for 9.1 and one more file included.

Still needs a coding standards rule, as pointed out in #8, so that we don't have to keep fixing this time and time again.

I was hoping this could be fixed in #2972224: Add .cspell.json to automate spellchecking in Drupal core but it seems hyphenated words are not recognised by cspell. I tried adding "e-mail" to the flagWords section of the config file but it didn't spot any of the uses in core.

Therefore I think the way to fix this forever is get a rule added to Coder that can check for this, if possible.

Updating a patch for #8
@longwave Let me see how a rule can be added in the coder.

Verified and tested by applying the patch #20.It was applied successfully and looks good to me.Can be moved to RTBC.

Steps to test-
1. Go to the a/core/ etc.
2. Search for the email.

BeforePatch -

After Patch -

After Patch all files -

Patch #20 applied successfully after patch all the e-mail changed to email and working fine Thanks for the patch

What we need here is a new rule added to the coder project to check our code for adding e-mail as we're obviously not going to remember this decision in the future.

This was pointed out in #8, #15, and #17. See #8 for more details.

Also, please don't post screen shots just to show the patch applies. That is what DrupalCI is for, you don't need to confirm that. If the patch hasn't been tested in a while you can trigger a retest to confirm that it applies and that the tests pass.

Everyone, remember to read the issue before working on patches. It was pointed out way back on #8 that a patch here was not the next step. The contributor guide on Drupal.org has information about how to contribute. There are also clear guidelines for How is credit granted for Drupal core issues.. Adjusting credit accordingly.

As pointed in #8 a sniff needs to be added in the Coder project. The issue there is #2278995: Add check for e-mail vs email to codesniffer. Until that is complete, this is postponed.

I tried again today to use cspell for this. I added "e-mail" to the flagWords and ran spellcheck on core and the instances were found. So, something has changed since longwave tried this in #17.

A core committer explained in #8 that work was not needed until a sniff was made in Coder. And that was repeated in #15 and #17. Patches and screenshots continued to be posted. That is not helping to resolve this and make noises in the issue. I am removing credit per How is credit granted for Drupal core issues.

Attached patch against Drupal 10.1.x

Let's get this back on track.

I have made a new patch, from scratch. I added 'e-mail' as a flag word and the spell checked all of core to find the instances. I fixed those and spell checked again. The dictionary does not need to be changed. I haven't included an interdiff because the previous patches include changes to migrate related files and that will just add noise to the interdiff.

The reroll in #36 does not have a diff and it didn't take into account the previous comments about the change of approach nor that the changes to migrate files (#8) should be removed. Therefor, I am removing credit.

Ran yarn spellcheck:core locally and it didn't return any errors:

CSpell: Files checked: 14818, Issues found: 0 in 0 files

Reviewed the patch manually to confirm all of the changes there look good 👍

+++ b/core/.cspell.json
@@ -49,7 +49,8 @@
     "flagWords": [
       "grey",
       "hte",
-      "please"
+      "please",
+      "e-mail"
     ],

Nitpick: should we keep this list in alphabetical order?

Yes, they should

Interdiff looks good 👍

Random fail: #3376563: Random test fail in Drupal\Tests\Component\Utility\RandomTest::testRandomMachineNamesUniqueness.

Committed 758cc0e and pushed to 11.x. Thanks!

Credit on this seems to have been lost, re-adding.

As this has been fixed without the use of a new sniff in Coder, it is confusing to have #2278995: Add check for e-mail vs email to codesniffer linked in the IS, therefore I have removed it. It is still in the related issues, which is OK.