\Drupal\Component\Diff\Diff::reverse()

CommentFileSizeAuthor
#15 reroll_diff_12-15.txt5.67 KBmedha kumari
#15 3043006-15.patch4.45 KBmedha kumari
#13 interdiff_11-12.txt476 bytesimmaculatexavier
#13 3043006-12.patch7.28 KBimmaculatexavier
#12 reroll_diff_2-11.txt3.18 KBimmaculatexavier
#12 3043006-11.patch7.29 KBimmaculatexavier
#2 drupal-3043006-2-diff_reverse.patch7.3 KBsweetchuck

Issue fork drupal-3043006

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sweetchuck created an issue. See original summary.

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Active » Needs review
StatusFileSize
new drupal-3043006-2-diff_reverse.patch7.3 KB

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs review » Needs work
Issue tags: -Diff integration +Bug Smash Initiative, +Needs issue summary update, +Needs reroll, +Novice

This is still applicable.

The tasks here are suitable as a first time issue adding novice tag. I took a look at the test and I think it would help to have a test with an array that has only one element and that changes. I think it would make it easier to see the reverse failure.

This needs an issue summary update, see Write an issue summary for an existing issue for guidance.

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !2375

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
StatusFileSize
new 3043006-11.patch7.29 KB
new reroll_diff_2-11.txt3.18 KB

Rerolled patch against #2 for 9.5.x

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 3043006-12.patch7.28 KB
new interdiff_11-12.txt476 bytes

Fixed the custom commands against #11

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

medha kumari’s picture

medha kumari
Location Jaipur
commented
Issue tags: -Needs reroll, -Novice +Config novice
StatusFileSize
new 3043006-15.patch4.45 KB
new reroll_diff_12-15.txt5.67 KB

Rerolled patch #12 in 10.1.x and fixed whitespace.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3299678: Deprecate DiffEngine and replace with sebastian/diff

Note, Diff::reverse is unused in core and #3299678: Deprecate DiffEngine and replace with sebastian/diff there's a proposal to deprecate it.

Status: Needs review » Needs work

The last submitted patch, 15: 3043006-15.patch, failed testing. View results

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

Diff::reverse is unused in core

That means, Drupal core provides it, and any contrib can|might rely on it.
Diff component should work without any problem.

there's a proposal to deprecate it.

Maybe the Diff component is deprecated, maybe it will be replaced in 10.x,
even in those cases, Diff component should work without any problem in 9.x.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.