Problem/Motivation

From https://www.drupal.org/project/drupal/issues/2976394#comment-12938274

Drupal\Tests\field\Functional\Hal\FieldConfigHalJsonCookieTest::testGet
Exception: TypeError: Argument 1 passed to Symfony\Component\HttpFoundation\Response::setCharset() must be of the type string, null given, called in /var/www/html/core/modules/rest/src/EventSubscriber/ResourceResponseSubscriber.php on line 210
Symfony\Component\HttpFoundation\Response->setCharset()() (Line: 496)

Drupal\Tests\action\Functional\ActionListTest::testEmptyActionList
Exception: TypeError: Argument 1 passed to Symfony\Component\HttpFoundation\Response::setCharset() must be of the type string, null given, called in /var/www/html/core/lib/Drupal/Component/HttpFoundation/SecuredRedirectResponse.php on line 43
Symfony\Component\HttpFoundation\Response->setCharset()() (Line: 496)

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 interdiff.txt1002 bytesgábor hojtsy
#4 3027835-4.patch1.83 KBgábor hojtsy
#4 3027835-4-combined.patch157.6 KBgábor hojtsy
#2 3027835.patch871 bytescatch
#2 3027835-combined.patch156.63 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3027835-combined.patch156.63 KB
new 3027835.patch871 bytes

This might be all we need to do.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

There is also the same fail in ResourceResponseSubscriber.php as in the paste :) There does not seem to be other affected code. Full output:

$ git grep "setCharset("
core/lib/Drupal/Component/HttpFoundation/SecuredRedirectResponse.php: $this->setCharset($response->getCharset());
core/modules/rest/src/EventSubscriber/ResourceResponseSubscriber.php: $final_response->setCharset($response->getCharset());
core/tests/Drupal/Tests/Component/HttpFoundation/SecuredRedirectResponseTest.php: $redirect->setCharset('ibm-943_P14A-2000');

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new 3027835-4-combined.patch157.6 KB
new 3027835-4.patch1.83 KB
new interdiff.txt1002 bytes

There you go.

The last submitted patch, 2: 3027835-combined.patch, failed testing. View results

The last submitted patch, 4: 3027835-4-combined.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented

Patch up at #3027872: [symfony 4] The default value of the "$secure" and "$samesite" arguments of "Symfony\Component\HttpFoundation\Cookie::__construct"'s constructor will change.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Can't see any downsides.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed db42557 and pushed to 8.7.x. Thanks!

  • larowlan committed db42557 on 8.7.x 
    Issue #3027835 by Gábor Hojtsy, catch: [symfony 4]  Argument 1 passed to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.