As case mentioned in #147947, this patch remap {boxes}.body as BLOB type.

The code logic should be correct, but it is now buggy for MySQL. It is because of INSERT DELAYED implementation in db_insert() which buggy when call db_last_insert_id() just after it, and MySQL don't support default value for TEXT/BLOB. I will mention the above bugs in other issues.

CommentFileSizeAuthor
#3 boxes-body-1223484987.patch3.97 KBhswong3i
#2 boxes-body.patch5.09 KBhswong3i
#1 boxes-body.patch4.09 KBhswong3i
boxes-body.patch3.22 KBhswong3i

Comments

hswong3i’s picture

hswong3i commented
Status: Needs work » Needs review
StatusFileSize
new boxes-body.patch4.09 KB

Remove the use of db_last_insert_id(), and also merge with http://drupal.org/node/300219 for correct schema definition.

MySQL:

  • update.php: pass (remember to access admin/build/themes and re-click active and default theme after update.php, it should be another bug across D6/7)
  • Insert new custom block: pass, both flash install or after upgrade.
  • Update existing custom block: pass, both flash install or after upgrade.

PostgreSQL:

  • update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
  • Insert new custom block: pass, for flash install
  • Update existing custom block: pass, for flash install
hswong3i’s picture

hswong3i commented
StatusFileSize
new boxes-body.patch5.09 KB

Revamp with drupal_write_record() for simpler handling.

When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for pid and uid when compare with using db_insert() directly.

Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

hswong3i’s picture

hswong3i commented
StatusFileSize
new boxes-body-1223484987.patch3.97 KB

Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.

Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
Version: 7.x-dev » 8.x-dev

Moving this to D8 now that #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB has been moved to D8 as well.

roma.k’s picture

roma.k commented
Priority: Normal » Critical
catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal
Status: Needs work » Needs review

Not critical. May not even be valid any more.

Priority: Critical » Normal
Status: Needs review » Needs work

The last submitted patch, boxes-body-1223484987.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)