MySql driver throws a generic DatabaseExceptionWrapper for integrity violation at insertion when column has no default

1. +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php
   @@ -373,20 +373,18 @@ public function testBundleFieldCreateDeleteWithExistingEntities() {
        catch (\RuntimeException $e) {
   ...
   +      // Keep throwing it.
   +      throw $e;
        }
   

   These lines can be removed. They are only doing the default thing.

2. 
   ...
   +      throw new IntegrityConstraintViolationException($message, is_int($e->getCode()) ? $e->getCode() : 0, $e);
   

   Why are we doing an is_int() test? Every where else in core we just use the $e->getCode() value.

The patch also needs a reroll.

Rerolled patch for 9.1.x and also done changes as mentioned in #16, please review.

Kindly review a new patch.

Patch looks good. I got just one remark:

+++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php
@@ -482,20 +482,16 @@ public function testBundleFieldCreateDeleteWithExistingEntities() {
     catch (\RuntimeException $e) {

This line can also be removed.

Also my question from comment #16.2 is still open.

Here I have made changes as per comment #20.

@daffie and @ravi.shankar , in #19 i have intentionally skipped the 16.2, as here the PDOException would store 'HY000', which fails the signature() which is mentioned mentioned by @mondrake.

All my points are addressed.
All code changes look good to me.
For me it is RTBC.

Patch looks reasonable to me, but needs a reroll.

Re-roll patch created, Please review.

+++ b/core/lib/Drupal/Core/Database/Driver/mysql/Connection.php
@@ -90,6 +91,24 @@ public function query($query, array $args = [], $options = []) {
+    // default value indicated in schema, MySql returns a 1364 error code.

Nitpick, and haven't looked at the patch in full, but the correct capitalization is "MySQL".

Fixed test, Please review.

Back to RTBC.

FILE: ...ts/Drupal/KernelTests/Core/Entity/EntityDefinitionUpdateTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 7 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Fixed this on commit.

Committed bacf782 and pushed to 9.1.x. Thanks!

I just realised after commit, that IntegrityConstraintViolationException doesn't extend DatabaseExceptionWrapper - so if someone was catching DatabaseExceptionWrapper specifically for this case, it might fail. This seems extremely unlikely, so I don't think it even needs a change record, but noting here in case anyone wants to do one just in case. I do think it's a reason to make this issue 9.1.x only though.