Problem/Motivation

Proposed resolution

Remove all three login blocks from the default configuration! Since they do not hurt in any way, we should not add an update function, but just remove it for new installations. As explained above it is very unlikely that people will miss them, and if they are in fact needed for some sites they can easily be re-configured. It just doesn't make sense to provide them by default.

CommentFileSizeAuthor
#6 interdiff-2-6.txt460 bytesmitrpaka
#6 2994579-6.patch2.44 KBmitrpaka
#2 2994579-2.patch2.53 KBidebr

Comments

tstoeckler created an issue. See original summary.

idebr’s picture

Status: Active » Needs review
StatusFileSize
new2.53 KB

Attached patch removes the user_login_block configuration from these installation profiles:
- demo_umami
- minimal
- standard

Status: Needs review » Needs work

The last submitted patch, 2: 2994579-2.patch, failed testing. View results

tstoeckler’s picture

Thanks! The patch looks perfect. I didn't look into the test failure yet, I would assume we can just adapt the assertion to expect one block less than before, but not 100% sure.

tstoeckler’s picture

Yeah, I looked at the test now and simply changing

      'block' => 35,

to

      'block' => 34,

in \Drupal\Tests\migrate_drupal_ui\Functional\d6\MigrateUpgrade6Test::getEntityCounts() should be sufficient.

mitrpaka’s picture

Status: Needs work » Needs review
StatusFileSize
new2.44 KB
new460 bytes
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @mitrpaka, that looks perfect! Let's get rid of some waste in Drupal ;-)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2994579-6.patch, failed testing. View results

tstoeckler’s picture

Status: Needs work » Reviewed & tested by the community

Random failure

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8735b60 and pushed to 8.7.x. Thanks!

  • alexpott committed 8735b60 on 8.7.x
    Issue #2994579 by mitrpaka, idebr, tstoeckler: Remove obsolete login...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.