Problem/Motivation

Blocked in #2935932: Add a FieldDefinition class for defining bundle fields in code..

In EntityFieldManager we automatically make Drupal aware of field storage definitions for fields defined using BaseFieldDefinition.

Proposed resolution

Since BundleFieldDefinition is both a field definition and a field storage definition, can we cut out the step of implementing the storage hook?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2980922-4.patch5.01 KBsam152

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
Parent issue: » #2346347: Finalize API for creating, overriding, and altering code-defined bundle fields
Related issues: +#2935932: Add a FieldDefinition class for defining bundle fields in code.
sam152’s picture

sam152 commented
Title: [PP-1] Applicable bundle field definitions defined in code should not have to manually implement entity_field_storage_info. » [PP-1] Applicable bundle field definitions defined in code should not have to manually implement hook_entity_field_storage_info.
sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new 2980922-4.patch5.01 KB

Starting point for this. Lets see what the testbot says.

Status: Needs review » Needs work

The last submitted patch, 4: 2980922-4.patch, failed testing. View results

amateescu’s picture

amateescu commented

Since BundleFieldDefinition is both a field definition and a field storage definition, can we cut out the step of implementing the storage hook?

The assumption for the current SI is not necessarily true, because I'm not sure we actually want BundleFieldDefinition to be both a field definition and a field storage definition, as discussed in #2935932-22: Add a FieldDefinition class for defining bundle fields in code..

sam152’s picture

sam152 commented

Indeed! We can consider this issue blocked in implementation and conceptually speaking too.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: [PP-1] Applicable bundle field definitions defined in code should not have to manually implement hook_entity_field_storage_info. » Applicable bundle field definitions defined in code should not have to manually implement hook_entity_field_storage_info.

Parent issue fixed.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.