Change ModuleInstallerInterface::uninstall() method doc comment that ModuleUninstallValidatorException can be thrown

Good catch!

+++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
@@ -56,6 +56,9 @@ public function install(array $module_list, $enable_dependencies = TRUE);
+   *   Thrown when uninstall validation fails.

This should be a complete sentence - see https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

Also, it looks like install() can also throw:

          throw new ExtensionNameLengthException("Module name '$module' is over the maximum allowed length of " . DRUPAL_EXTENSION_NAME_MAX_LENGTH . ' characters');

Hi,

I have added a new patch for this please apply this.

Thanks,

Thanks for the updated patch! This is getting close I think!

1. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -37,6 +37,9 @@
   +   *   Thrown when the extension's name length exceeds the allowed maximum.
   

   Could we give the maximum here, as a reference to DRUPAL_EXTENSION_NAME_MAX_LENGTH. It looks like it won't form a link -- see #2988368: global and class constants are not linked to -- but it would still be useful. Sorry, should have thought of that in my earlier review.

2. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -56,6 +59,9 @@ public function install(array $module_list, $enable_dependencies = TRUE);
   +   *   Thrown when uninstalling a module that did not validate.
   

   This seems vague, but the exception class itself doesn't say any more.

   So I'd say that vagueness should be fixed on the exception class rather than here.

Please find the updated patch.

Thanks,

Hi,

I have applied this patch and tested for review. it's working fine and also code as per standard with well written.

Thanks

Nearly there, but not quite!

1. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -37,6 +37,9 @@
   +   *   Thrown when the extension's name length exceeds than 50 character.
   

   This should mention the constant, rather than repeat the hardcoded value.

2. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -56,6 +59,9 @@ public function install(array $module_list, $enable_dependencies = TRUE);
   +   *   Thrown when uninstalling a module that did not validate due to some reasons.
   

   This line needs to be wrapped.

Hi,

Please find the updated patch.

Thanks,

Fixed one whitespace error in the last patch

LGTM.

1. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -37,6 +37,10 @@ interface ModuleInstallerInterface {
   +   *   DRUPAL_EXTENSION_NAME_MAX_LENGTH.
   

   The english is off here

   suggest

   %s/length exceeds than/is longer than/

2. +++ b/core/lib/Drupal/Core/Extension/ModuleInstallerInterface.php
   @@ -56,6 +60,10 @@ public function install(array $module_list, $enable_dependencies = TRUE);
   +   *   Thrown when uninstalling a module that did not validate due to certain
   +   *   reasons.
   

   Same here, suggest

   "Thrown when validation prevented the module from being uninstalled"

I think this is a task more than a bug

Updated as per #20

Thanks for the reroll.

Missing documentation is a documentation bug, isn't it?

Updating issue credits

Committed b9f132b and pushed to 9.3.x. Thanks!

Backported to 9.2.x