Problem/Motivation

Continuing from https://www.drupal.org/project/drupal/issues/2951715#comment-12559059

core/modules/migrate/src/Plugin/migrate/process/MenuLinkParent.php:100:    
throw new MigrateSkipRowException()

Proposed resolution

Log a message to MigrateSkipRowException to clearly explain why the row is skipped.

Remaining tasks

Patch

User interface changes

NA

API changes

NA

Data model changes

NA

CommentFileSizeAuthor
#6 2959106-6.patch2.2 KBjofitz
#2 2959106-2.patch602 bytesrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2959106-2.patch602 bytes
quietone’s picture

quietone commented
Parent issue: » #2959444: [Meta] Improve exception messages in process plugins

Add to meta

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work 
+++ b/core/modules/migrate/src/Plugin/migrate/process/MenuLinkParent.php
@@ -97,7 +97,7 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
+    throw new MigrateSkipRowException("Skipped because of there is no parent link found.");

Let's print all the contextual data in the exception please.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue tags: +Nwdug_may18
jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2959106-6.patch2.2 KB

No interdiff as started again from scratch.
Also includes test.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Applied patch, ran test, the message is clear, informative and follows PHP Exceptions. I like it. Thanks!

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed b9fdef8387 to 8.7.x and f58cfcbb6d to 8.6.x. Thanks!

  • alexpott committed b9fdef8 on 8.7.x 
    Issue #2959106 by rakesh.gectcr, Jo Fitzgerald, quietone, heddn: Log...

  • alexpott committed f58cfcb on 8.6.x 
    Issue #2959106 by rakesh.gectcr, Jo Fitzgerald, quietone, heddn: Log...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.