Cleanup update schema for already migrated sites

Did you experience any problems or error messages while running the DB updates?
It seems that it still thinks that the module is enabled, but the updb code should have uninstalled it. I assume an additional cache clear doesn't solve the warning message, right?

Have you tried this - https://www.drupal.org/node/2487215

I'm also getting the same error. No warnings or anything during the upgrade process.

Same error here, also no warnings/errors during upgrade process.

To make this a bit more useful post, and saving anyone the extra click for #4, this does the trick:

drush sql-query "DELETE FROM key_value WHERE collection='system.schema' AND name='media_entity'"

But I also agree with #5. It's a last resort and not something you want every user that is going to migrate to Core Media having to do.

Hit this as well today. This is because Media Entity is uninstalled from within an update function from the module itself. What happens is that even though during the installation the schema version is correctly removed, after the update has finished update_do_one() calls drupal_set_installed_schema_version($module, $number) so that there will still be a lingering schema version afterwards.

Afterwards any call to drupal_load_updates() will find that schema version and will call module_load_install('media_entity') which will trigger the error above.

Not sure yet what to do about this, but it's certainly a major issue.

I guess we could maybe run something in core to clean this up?

This is what fixed it for me in a custom module.

/**
 * Remove 'media_entity' from the system schema list.
 */
function MYMODULE_update_8002() {
  $schema_store = \Drupal::keyValue('system.schema');
  $schema_store->delete('media_entity');
}

Should we add this to the core media module to fix this for installations, which have been updated already?

Yes, I think that would make sense. It certainly must be run by code that is not inside media_entity itself, so I think the core media module would be a logical place, especially since something along the lines of #9 should suffice and that's not really a lot of code to maintain.

I'd be interested to hear what the Media maintainers say about this, though.

Tentatively moving the issue to the Core media system. Feel free to revert, but I think that makes the most sense.

I agree this is an annoying issue, but I don't think we should solve this in a core update hook. Maybe a new branch of media_entity with a uninstall hook that fixes this? You can install and directly uninstall media_entity 3.x to fix it if you don't want to add your own update hook?

I am not sure that it is nice to ask people to install a specific version of the media_entity module as they moved from it to the core one. We cannot reach to all the people, but with a core media update we'll fix all sites silently without having to inform anyone about anything. The media core module is aware of the media_entity module - see media_requirements() in media.install, therefore I don't think there is a problem with adding a simple update to the media module.

@tstoeckler Thanks for the code. That solved it for me.

For those GUI users there should be some sort of resolution to this issue that does not involve a custom module or the command line.

See the newly opened #3063734: Support uninstalling the module providing the update hook in hook_update_N for some updates on this.

I think we can close this issue since #3063719: Remove media_entity from the update schema list was merged

I personally think it would be nice to clean this up for people that have already done the upgrade, since Media in Core has been stable for a while. We could add an update hook to the Media module. Going on #9, we could do something like this:

/**
 * Remove obsolete 'media_entity' reference from the schema store.
 */
function media_update_****() {
  $schema_store = \Drupal::keyValue('system.schema');
  $schema_version = $schema_store->get('media_entity', FALSE);
  // Early versions of the Media Entity upgrade path did not remove the schema
  // version properly after uninstalling itself. Remove the obsolete reference in
  // this case.
  if ($schema_version && ($schema_version == 8201) && !\Drupal::moduleHandler()->moduleExists('media_entity')) {
    $schema_store->delete('media_entity');
  }
}

Sounds like a plan. I am moving this back to the media_entity issue queue

this can't be solved in media_entity, because that is already uninstalled, it can only be done from a module that's still installed and media in core would be an obvious choice.

Ahh, stupid me. 🙈