Drupal 8 is almost fully object-orientiered everywhere except of hooks. In the other hand it is still rather flexible tool. A lot of core modules now use .module file just only for collecting information about hooks, delegating other classes, as usual injectable, hooks implementation. In order to implement standard oop approach here, it would be nice to have hook plugin manager, that collects hooks implementations. As alternative this can be service collector or some event (symfony approach), but plugin would suite the best.

Comments

olexyy.mails@gmail.com created an issue. See original summary.

olexyy.mails@gmail.com’s picture

olexyy.mails@gmail.com commented

That would be the first step to deprecating static calls of services. As for manager itself, I see two approaches.
First: each plugin could have machine name according to hook naming convention and only one method to be called. So plugin would be picked up by machine name. In result each hook would have one file.
Second approach to have this method not for implementation, but for information of hooks implementation, so several hooks could be implemented in one plugin.

cilefen’s picture

cilefen commented
Related issues: +#1972304: Add a HookEvent

Hi! This is an interesting idea however it seems to be duplicating existing efforts.

olexyy.mails@gmail.com’s picture

olexyy.mails@gmail.com commented

Here we can discuss plugins implementation, other issues about tagged service and events.

olexyy.mails@gmail.com’s picture

olexyy.mails@gmail.com commented

I've just started basic implementation as contrib by altering module_handler service.

Current implementation has some advantages:

- it should be rather fast;
- it uses caching and static;
- priority is supported;
- we have progress in naming convention problems;
- we can inject services to classes that implement hooks;

Repo:
https://github.com/Olexyy/hook_manager.git

If there are any thoughts, please share.

olexyy.mails@gmail.com’s picture

olexyy.mails@gmail.com commented

Related working project.

https://www.drupal.org/sandbox/olexyymailsgmailcom/hook_manager

There is now added 'static' map for alter hooks, changed priority logic.
This can be merged with core, if in general is ok and performance is enough.

olexyy.mails@gmail.com’s picture

olexyy.mails@gmail.com commented

The idea is rather simple:
Annotation to plugin contains list of canonical names for hooks with corresponding priority. (f.e. hook_theme => 0)
We need to implement this hook as method in camel case, so this is public function hookTheme();

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Closed (duplicate)

Duplicate of #3442009: OOP hooks using attributes and event dispatcher